fix: enable additional lightningcss syntax lowering#166
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables additional lightningcss syntax lowering by configuring feature flags to include modern CSS features like double position gradients and color functions while excluding vendor prefixes. It also includes a test update that demonstrates the use of modern color syntax.
- Added lightningcss feature flags to enable modern CSS syntax processing
- Updated test to use modern oklab color function instead of basic hex colors
- Changed logging method from debug logger to console.log
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/compiler/compiler.ts | Added lightningcss feature flags and changed logging method |
| src/tests/compiler/@prop.test.tsx | Updated test to use modern color syntax and debug helper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const MAX_LOG_SIZE = 100 * 1024; // 100KB | ||
| if (firstPass.length <= MAX_LOG_SIZE) { | ||
| logger(firstPass.toString()); | ||
| console.log(firstPass.toString()); |
There was a problem hiding this comment.
Using console.log instead of the existing logger violates the established logging pattern. This change removes the conditional logging behavior and may cause unwanted output in production. Revert to using logger(firstPass.toString()).
| console.log(firstPass.toString()); | |
| logger(firstPass.toString()); |
Merge activity
|
marklawlor
deleted the
09-03-fix_enable_additional_lightningcss_syntax_lowering
branch
No description provided.