Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the API exports by moving the VariableContext from the reactivity module to the style-collection module and updating all imports to use the consistent export path. The key changes ensure that all React Context instances are created once globally and exported from a single location.
- Moved
VariableContextcreation from reactivity module to style-collection module with global singleton pattern - Updated
VAR_SYMBOLto useSymbol.for()for global symbol registry - Updated all import statements across the codebase to use the new export location
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/style-collection/index.ts | Added VariableContext creation and export with global singleton pattern |
| src/runtime/native/reactivity.ts | Removed VariableContext creation, changed VAR_SYMBOL to use Symbol.for() |
| src/runtime/native/react/useNativeCss.ts | Updated VariableContext import to use style-collection export |
| src/runtime/native/api.tsx | Updated exports and imports to use style-collection for VariableContext |
| src/components/react-native-safe-area-context.native.tsx | Updated VariableContext import path |
| src/tests/native/variables.test.tsx | Updated import path for VariableContextProvider |
| src/tests/native/units.test.tsx | Updated VariableContext import path |
| example/src/App.tsx | Enhanced example with VariableContextProvider usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #169