Skip to content

Feature/ros distro as param #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chbroecker wants to merge 6 commits into
base: main
Choose a base branch
from
+35 −4
Draft

Feature/ros distro as param #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aebe9d7
add reusable workflow for checking formatting via pre-commit
Cakem1x May 20, 2025
f532066
run linters in ubuntu 24.04
Cakem1x May 20, 2025
1d80936
add ros pkg sources
Cakem1x May 20, 2025
48291af
run linters in our ubuntu jazzy container
Cakem1x May 20, 2025
6c07d2e
add ros distro as workflow inputs
Cakem1x May 20, 2025
fe331fe
rename workflow file to reflect its generic nature
Cakem1x May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/linters_via_pre_commit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Linters via pre commit

on:
workflow_call:

inputs:
ros_distro:
required: true
type: string

jobs:
linters_via_pre_commit:
name: Linters via pre commit
runs-on: ubuntu-latest
container:
image: "ghcr.io/naturerobots/ros2_${{ inputs.ros_distro }}_build:latest"
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
options:
--user root
steps:
- uses: actions/checkout@v4
- uses: pre-commit/action@v3.0.1
with:
extra_args: --all-files --hook-stage manual
13 changes: 9 additions & 4 deletions .github/workflows/humble_ci.yaml → .github/workflows/ros_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
name: Humble CI - Build and Test
name: ROS Build and Test

on:
workflow_call:

inputs:
ros_distro:
required: true
type: string

jobs:
build_and_test:
runs-on: ubuntu-latest
permissions:
contents: read
packages: read
container:
image: ghcr.io/naturerobots/ros2_humble_build:latest
image: ghcr.io/naturerobots/ros2_${{ inputs.ros_distro }}_build:latest
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -31,8 +36,8 @@ jobs:
- name: Build and test
uses: ros-tooling/action-ros-ci@0.3.13
with:
package-name: ${{env.PACKAGES_FOR_CI}}
target-ros2-distro: humble
package-name: ${{ env.PACKAGES_FOR_CI }}
target-ros2-distro: ${{ inputs.ros_distro }}
vcs-repo-file-url: $GITHUB_WORKSPACE/source_dependencies.yaml
rosdep-check: true
import-token: ${{ secrets.ORGANIZATION_PRIVATE_PAT }}