Fix PR #1749 review follow-ups — m2 attribute default, inline helper, docstring tone

Author: Flo0807

lib/backpex/html/layout.ex

@@ -501,9 +501,8 @@ defmodule Backpex.HTML.Layout do
       "A unique id for this section. Used to save and load the opening state of this section and to wire aria-controls, so every section on the page must have its own."
 
   attr :sidebar_section_states, :map,
-    default: %{},
     doc:
-      "map of section states. Read from the parent's `@sidebar_section_states` assign when not passed explicitly; falls back to `%{}` (all sections open by default)."
+      "map of section states. When the attr is omitted, the component falls back to the parent's `@sidebar_section_states` assign (via `assign_new/3`), or `%{}` if the parent didn't set one. Unknown section ids default to open."
 
   slot :inner_block
   slot :label, required: true, doc: "label to be displayed on the section."

lib/backpex/preferences/key.ex

@@ -22,7 +22,7 @@ defmodule Backpex.Preferences.Key do
   making stored preferences hard to reason about. Switching the whole key to
   colons lets the module live as a single atomic segment.
 
-  ## Separator precedence (read carefully)
+  ## Separator precedence
 
   A single `":"` anywhere in the key flips the whole key to colon-split
   parsing. There is no "mixed" mode. Concretely:

lib/backpex/preferences/router.ex

@@ -138,9 +138,6 @@ defmodule Backpex.Preferences.Router do
 
     # Sort order: named patterns beat :default, longer patterns beat shorter,
     # exact matches beat wildcards at the same depth.
-    {1, length, bool_to_int(exact?)}
+    {1, length, if(exact?, do: 1, else: 0)}
   end
-
-  defp bool_to_int(true), do: 1
-  defp bool_to_int(false), do: 0
 end