Support readonly for all fields: changes for PR review

Author: gmazzamuto

lib/backpex/fields/belongs_to.ex

@@ -144,6 +144,7 @@ defmodule Backpex.Fields.BelongsTo do
           options={@options}
           prompt={@prompt}
           readonly={@readonly}
+          disabled={@readonly}
           translate_error_fun={Backpex.Field.translate_error_fun(@field_options, assigns)}
           help_text={Backpex.Field.help_text(@field_options, assigns)}
           phx-debounce={Backpex.Field.debounce(@field_options, assigns)}

lib/backpex/fields/boolean.ex

@@ -42,7 +42,7 @@ defmodule Backpex.Fields.Boolean do
         <BackpexForm.input
           type="toggle"
           field={@form[@name]}
-          readonly={@readonly}
+          disabled={@readonly}
           translate_error_fun={Backpex.Field.translate_error_fun(@field_options, assigns)}
           help_text={Backpex.Field.help_text(@field_options, assigns)}
           phx-debounce={Backpex.Field.debounce(@field_options, assigns)}

lib/backpex/fields/currency.ex

@@ -99,6 +99,7 @@ defmodule Backpex.Fields.Currency do
           type="text"
           field={@form[@name]}
           readonly={@readonly}
+          disabled={@readonly}
           translate_error_fun={Backpex.Field.translate_error_fun(@field_options, assigns)}
           help_text={Backpex.Field.help_text(@field_options, assigns)}
           phx-debounce={Backpex.Field.debounce(@field_options, assigns)}

lib/backpex/fields/inline_crud.ex

@@ -180,6 +180,7 @@ defmodule Backpex.Fields.InlineCRUD do
               <div class={if f_nested.index == 0, do: "mt-5", else: nil}>
                 <label for={"#{@name}-checkbox-delete-#{f_nested.index}"}>
                   <input
+                    :if={not @readonly}
                     id={"#{@name}-checkbox-delete-#{f_nested.index}"}
                     type="checkbox"
                     name={"change[#{@name}_delete][]"}

lib/backpex/fields/select.ex

@@ -78,6 +78,7 @@ defmodule Backpex.Fields.Select do
           options={@options}
           prompt={@prompt}
           readonly={@readonly}
+          disabled={@readonly}
           translate_error_fun={Backpex.Field.translate_error_fun(@field_options, assigns)}
           help_text={Backpex.Field.help_text(@field_options, assigns)}
           phx-debounce={Backpex.Field.debounce(@field_options, assigns)}

lib/backpex/fields/url.ex

@@ -63,6 +63,7 @@ defmodule Backpex.Fields.URL do
           phx-throttle={Backpex.Field.throttle(@field_options, assigns)}
           aria-labelledby={Map.get(assigns, :aria_labelledby)}
           readonly={@readonly}
+          disabled={@readonly}
         />
       </Layout.field_container>
     </div>

lib/backpex/html/core_components.ex

@@ -38,7 +38,7 @@ defmodule Backpex.HTML.CoreComponents do
       </.dropdown>
   """
   attr :id, :string, required: true, doc: "unique identifier for the dropdown"
-  attr :readonly, :boolean, default: false
+  attr :readonly, :boolean, default: false, doc: "whether the dropdown is readonly"
   attr :class, :any, default: nil, doc: "additional classes for the outer container element"
 
   slot :trigger, doc: "the trigger element to be used to toggle the dropdown menu" do

lib/backpex/html/form.ex

@@ -47,13 +47,6 @@ defmodule Backpex.HTML.Form do
   slot :inner_block
 
   def input(%{field: %Phoenix.HTML.FormField{} = field} = assigns) do
-    assigns =
-      if Map.has_key?(assigns.rest, :disabled) do
-        assigns
-      else
-        put_in(assigns, [:rest, :disabled], Map.get(assigns.rest, :readonly) || false)
-      end
-
     assigns
     |> prepare_field_assigns(field, assigns.translate_error_fun)
     |> assign_new(:name, fn -> if assigns.multiple, do: field.name <> "[]", else: field.name end)
@@ -212,13 +205,6 @@ defmodule Backpex.HTML.Form do
               multiple pattern placeholder readonly required rows size step)
 
   def currency_input(%{field: %Phoenix.HTML.FormField{} = field} = assigns) do
-    assigns =
-      if Map.has_key?(assigns.rest, :disabled) do
-        assigns
-      else
-        put_in(assigns, [:rest, :disabled], Map.get(assigns.rest, :readonly) || false)
-      end
-
     assigns
     |> prepare_field_assigns(field, assigns.translate_error_fun)
     |> assign_new(:name, fn -> field.name end)
@@ -300,7 +286,7 @@ defmodule Backpex.HTML.Form do
   @doc type: :component
 
   attr :prompt, :string, required: true, doc: "string that will be shown when no option is selected"
-  attr :readonly, :boolean, default: false
+  attr :readonly, :boolean, default: false, doc: "whether the dropdown is readonly"
   attr :help_text, :string, default: nil, doc: "help text to be displayed below input"
   attr :not_found_text, :string, required: true, doc: "string that will be shown when there are no options"
   attr :options, :list, required: true, doc: "a list of options for the select"

lib/backpex/html/resource.ex

@@ -176,8 +176,9 @@ defmodule Backpex.HTML.Resource do
       |> assign(:field_options, field_options)
       |> assign(:type, :form)
 
+    # this is needed to apply `:readonly` to individual fields in `Backpex.Fields.InlineCRUD`
     assigns =
-      if assigns[:readonly] == true do
+      if assigns[:readonly] do
         assigns
       else
         assign(assigns, :readonly, Backpex.Field.readonly?(field_options, assigns))