Remove unused jason dependency#2115
Merged
Merged
Conversation
jason is declared in mix.exs but never used: it appears nowhere in lib/ or priv/templates/, and git history shows no call site was ever removed — it has been unused for as long as it has been declared. mix.lock is unchanged, since jason stays as a transitive dependency of credo, esbuild, igniter and mix_audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
{:jason, "~> 1.2"}is declared inmix.exsbut never used.Evidence
It appears nowhere outside its own declaration:
Unlike
number(#2113), there is no commit that removed a call site —git log -S"Jason." -- lib/is empty across all branches. It appears to have been unused for as long as it has been declared.Backpex does not serialize anything itself; host applications configure their own JSON library for Phoenix and Ecto.
Impact
mix.lockis unchanged:jasonremains as a transitive dependency ofcredo,esbuild,igniterandmix_audit. This only removes the direct declaration, so nothing is dropped from the resolution — the point is that Backpex no longer constrains a package it does not use.Verification
mix lintpasses end to end (compile --warning-as-errors,deps.unlock --unused,format,credo, 100 doctests + 174 tests, 0 failures), andmix docs --warnings-as-errorsbuilds.Context
Found by a dependency check I am preparing separately, which reports dependencies that are declared but never referenced by the compiled code — the blind spot that let
numbersit unused for two years until it blockeddecimal3.x (#2113).mix deps.unlock --check-unusedcannot see this class of problem, since it only comparesmix.lockagainstmix.exs.