WIP: Geewallet payments#1
Closed
canndrew wants to merge 2 commits into
Closed
Conversation
Importing fsc.props, which overrides the values of FscToolPath and FscToolExe, breaks my build on ubuntu with .NET Core 3.1. Removing the import allows the build to work fine. This commit should be reviewed later if we want to support .NET Core 2.0 (which is apparently what the overrides are for).
Member
|
Can you re-create this PR again opening a new PR? I didn't have GithubActions enabled when you opened it so I guess that's the reason we don't see any CI status here. |
knocte
reviewed
Mar 15, 2020
| [] |> Ok | ||
|
|
||
| // ---------- normal operation --------- | ||
| | ChannelState.Normal state, GeewalletPayment cmd when state.LocalShutdown.IsSome || state.RemoteShutdown.IsSome -> |
Member
There was a problem hiding this comment.
please rename all occurrences of GeewalletPayment to MonoHopUnidirectionalPayment; I'd prefer DNL to not mention geewallet at all
canndrew
force-pushed
the
geewallet-payments
branch
from
March 16, 2020 11:27
7576c8f to
b24eaca
Compare
Author
|
I'm closing this so I can re-open another PR... Edit: The new PR is here: #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for the implementation for the geewallet payments. Geewallet payments are implemented as their own lightning message type. Sending a payment requires sending a
geewallet_paymentmessage followed immediately by acommitment_signedwhich should be responded to with arevoke_and_ackand acommitment_signedfrom the counterparty.The
geewallet_paymentmessage will evolve intoupdate_add_htlconce we are able to get revocations (and therefore non-routable payments) working.There are two tests in
DotNetLightning.Infrastructure.Tests/ChannelOperationTests.fsfor geewallet payments - one which does not send therevoke_and_ackbut which passes, and one that does send it but doesn't pass.