Refactor#28

Open

aarani wants to merge 68 commits into

nblockchain:wip/upstreamfrom

aarani:wip/upstream

Commits on Jun 14, 2021

Remove ChannelAnnoucement field from NormalData

canndrew
authored and
aarani
committed
Remove NormalData.ChannelUpdate field

canndrew
authored and
aarani
committed
Merge WaitForFunding{Locked,Confirmed} states into Normal

canndrew
authored and
aarani
committed
Remove nextCommitments from AcceptedShutdownWhileWeHaveUnsignedOutgoingHTLCs

canndrew
authored and
aarani
committed
Remove ChannelState.Shutdown

canndrew
authored and
aarani
committed
Record remote's ShutdownScriptPubKey from open/accept channel msgs

canndrew
authored and
aarani
committed
Replace ShutdownMsg fields with ShutdownScriptPubKey in channel states

canndrew
authored and
aarani
committed
De-duplicate shutdown scripts

canndrew
authored and
aarani
committed
Remove unused fields from ClosingData

canndrew
authored and
aarani
committed
Change type of NegotiatingData.ClosingTxProposed

canndrew
authored and
aarani
committed
Change type (again) of NegotiatingData.ClosingTxPerformed

canndrew
authored and
aarani
committed
Remove MaybeBestUnpublishedTx from NegotiatingData

canndrew
authored and
aarani
committed
Remove ClosingTxProposed type

canndrew
authored and
aarani
committed
Track previous fee proposed by remote peer during fee negotiation

canndrew
authored and
aarani
committed
Move RemoteNextCommitInfoOpt into Channel

canndrew
authored and
aarani
committed
Move ShortChannelIdOpt out of NormalData into Channel

canndrew
authored and
aarani
committed
Remove handleMutualClose function

canndrew
authored and
aarani
committed
Remove claimCurrentLocalCommitTxOutputs

canndrew
authored and
aarani
committed
Add ChannelFlags type

canndrew
authored and
aarani
committed
Remove ChannelState

canndrew
authored and
aarani
committed
Move some channel fields into new StaticChannelConfig type

canndrew
authored and
aarani
committed
Move FeeEstimator into ChannelOptions

canndrew
authored and
aarani
committed
Remove redundant arg from New{In,Out}Bound methods

canndrew
authored and
aarani
committed
Factor reestablishment-creation into a method

canndrew
authored and
aarani
committed
Turn ApplyFundingLocked into a method

canndrew
authored and
aarani
committed
Make ApplyFundingConfirmedOnBC into a method

canndrew
authored and
aarani
committed
Make RemoteNextCommitInfoIfFundingLocked{,Normal} helper...

canndrew
authored and
aarani
committed
Make AddHTLC into a method

canndrew
authored and
aarani
committed
Make ApplyUpdateAddHTLC into a method

canndrew
authored and
aarani
committed
Make FulfillHTLC into a method

canndrew
authored and
aarani
committed
Make ApplyUpdateFulfillHTLC into a method

canndrew
authored and
aarani
committed
Make FailHTLC into a method

canndrew
authored and
aarani
committed
Make FailMalformedHTLC into a method

canndrew
authored and
aarani
committed
Make ApplyUpdateFailHTLC into a method

canndrew
authored and
aarani
committed
Make ApplyUpdateFailMalformedHTLC into a method

canndrew
authored and
aarani
committed
Make UpdateFee into a method

canndrew
authored and
aarani
committed
Make ApplyUpdateFee into a method

canndrew
authored and
aarani
committed
Make SignCommitment into a method:w

canndrew
authored and
aarani
committed
Make ApplyCommitmentSigned into a method

canndrew
authored and
aarani
committed
Make ApplyRevokeAndACK into a method

canndrew
authored and
aarani
committed
Make Close into a method

canndrew
authored and
aarani
committed
Make RemoteShutdown into a method

canndrew
authored and
aarani
committed
Make ApplyClosingSigned into a method

canndrew
authored and
aarani
committed
Remove Channel{Operation,Event}

canndrew
authored and
aarani
committed
Remove ChannelWaitingForFundingSigned.LastSent field

canndrew
authored and
aarani
committed
Remove ChannelWaitingForFundingCreated.TemporaryFailure field

canndrew
authored and
aarani
committed
Expand/Remove ChannelWaitingForFundingTx.LastReceived field

canndrew
authored and
aarani
committed
Remove WhichInput field from tx types

canndrew
authored and
aarani
committed
Seperate incoming and outgoing htlcs in CommitmentSpec

canndrew
authored and
aarani
committed
Move StaticChannelConfig into new SavedChannelState type

canndrew
authored and
aarani
committed
Move RemotePerCommitmentSecrets into SavedChannelState

canndrew
authored and
aarani
committed

Commits on Jun 18, 2021

Move ShortChannelId into SavedChannelState

canndrew
authored and
knocte
committed
Move {Local,Remote}Commit into SavedChannelState

canndrew
authored and
knocte
committed
Move proposed local changes out of LocalChanges

canndrew
authored and
knocte
committed
Move proposed remote changes out of RemoteChanges

canndrew
authored and
knocte
committed
Move Local,RemoteChanges into SavedChannelState

canndrew
authored and
knocte
committed
Core: remove unneeded MSat/Satoshis suffixes to non-primitive vars
knocte
committed
Core: better variable name than single letter (readability)
knocte
committed
Remove DomainUtils/Type.fs and its interface definitions

canndrew
authored and
knocte
committed
Make SignCommitment not return an Option

canndrew
authored and
knocte
committed
ApplyFundingConfirmedOnBC: error if depth insufficient

canndrew
authored and
knocte
committed
Fix ApplyFundingLocked

canndrew
authored and
knocte
committed
Fix ApplyFundingConfirmedOnBC

canndrew
authored and
knocte
committed
RemoteShutdown: give user local shutdown msg when they need it

canndrew
authored and
knocte
committed
Typo: NowKnown -> NotKnown

aarani
authored and
knocte
committed

Commits on Jun 22, 2021

Cosmetic: normalize 'self.' and 'x.' to 'this.' or '__.' for consistency
knocte
committed
Fix broken HTLC handling in Spec.Reduce function

aarani
authored and
knocte
committed
Fix closing_signed fee check

canndrew
authored and
aarani
committed