fix(git): commit.verboseオプションを削除#1147
Merged
Merged
Conversation
`verbose`で変更セットをバッファに入れておくことは、
GitHub Copilot Completeの精度を向上させます。
しかし現在commitlintがdiff部分に反応して行の長さをチェックしてしまうという問題と衝突します。
[{body,footer}-max-line-length may fail when git commit --verbose · Issue #437 · conventional-changelog/commitlint](conventional-changelog/commitlint#437)
少なくとも解決策の、
[fix(read): strip verbose diff from commit message by enaktes9-hub · Pull Request #4770 · conventional-changelog/commitlint](conventional-changelog/commitlint#4770)
がマージされるまでは、
`verbose`オプションを削除します。
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
home/core/git.nixからcommit.verbose = true;を削除する変更です。
コミットメッセージで削除理由が明確に説明されており、commitlintが--verbose時のdiff部分に反応して行長チェックに失敗する問題(conventional-changelog/commitlint#437)との衝突を回避するための妥当な対応です。修正PR(conventional-changelog/commitlint#4770)がマージされるまでの暫定措置という方針も明示されています。
単一行の設定削除でリスクはなく、Nixの構文・周辺設定への影響もありません。指摘事項はありません。
nvd diff: seminar (base: master)Version changesClosure size: 4776 -> 4776 (8 paths added, 8 paths removed, delta +0, disk usage -16B). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verboseで変更セットをバッファに入れておくことは、GitHub Copilot Completeの精度を向上させます。
しかし現在commitlintがdiff部分に反応して行の長さをチェックしてしまうという問題と衝突します。
{body,footer}-max-line-length may fail when git commit --verbose · Issue #437 · conventional-changelog/commitlint
少なくとも解決策の、
fix(read): strip verbose diff from commit message by enaktes9-hub · Pull Request #4770 · conventional-changelog/commitlint
がマージされるまでは、
verboseオプションを削除します。