feat(docker): customization of installed packages#122
Open
alexjsp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Docker env var:
WHD_EXTRA_PACKAGESthat when set installs those packages with apk on container launch.This allows users to add the packages their scripts require (ruby, or gh-cli, or whatever) without having to fork the image, or add pre-installation sections to all of their scripts. I think this is a better solution to problems like this one.
This did require changing the entrypoint script to initially run as root so it is able to install the packages with apk, the script then permanently drops to the unprivileged webhookd user before running the rest of the script and starting the server. (I believe this is the common approach used when an entrypoint needs to begin as root but does not want the whole docker running as root)