Closed
Conversation
Author
Author
|
Closing this in favor of PR #8 which also includes these validation fixes in addition to merged support for KDE 5/6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nclarius
There were frequent
TypeErrormessages in the journal showing up, and I believe they were contributing to inconsistency with the script being able to maintain the app groupings. Sometimes elements that were being checked were "undefined". The additional validations should prevent those errors, and seem to make the overall functioning of the app grouping much more consistent. Both Alt+Tabbing and clicking on a background window in a group will successfully bring all the related windows forward in my testing.Prior to adding this it seemed to be possible to damage the window list of an app group by clicking on a "background" window of a "background" app group, leading to only one window of that app group coming forward from then on. I was able to trigger this in two different app groups.
After adding these validation checks, I can't seem to replicate the issue. The grouping works much better.