Skip to content

Add error prevention validations#7

Closed
RedBearAK wants to merge 1 commit intonclarius:masterfrom
RedBearAK:patch-1
Closed

Add error prevention validations#7
RedBearAK wants to merge 1 commit intonclarius:masterfrom
RedBearAK:patch-1

Conversation

@RedBearAK
Copy link
Copy Markdown

@RedBearAK RedBearAK commented Oct 23, 2023

@nclarius

There were frequent TypeError messages in the journal showing up, and I believe they were contributing to inconsistency with the script being able to maintain the app groupings. Sometimes elements that were being checked were "undefined". The additional validations should prevent those errors, and seem to make the overall functioning of the app grouping much more consistent. Both Alt+Tabbing and clicking on a background window in a group will successfully bring all the related windows forward in my testing.

Prior to adding this it seemed to be possible to damage the window list of an app group by clicking on a "background" window of a "background" app group, leading to only one window of that app group coming forward from then on. I was able to trigger this in two different app groups.

After adding these validation checks, I can't seem to replicate the issue. The grouping works much better.

@RedBearAK
Copy link
Copy Markdown
Author

@nclarius - This PR should close issue #6 when merged.

@RedBearAK
Copy link
Copy Markdown
Author

Closing this in favor of PR #8 which also includes these validation fixes in addition to merged support for KDE 5/6.

@RedBearAK RedBearAK closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant