Skip to content

Commit 8ddbef1

Browse files
committed
remove dead tcp stream shim
1 parent 462ba28 commit 8ddbef1

2 files changed

Lines changed: 0 additions & 34 deletions

File tree

pkg/auditserver/server.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,6 @@ func (as *AuditServer) OnTraffic(c gnet.Conn) (action gnet.Action) {
234234
return newTransportAdapter(as.auditTransport, as.logger, as).OnTraffic(c)
235235
}
236236

237-
func (as *AuditServer) handleTCPStream(frame []byte, carryover []byte) []byte {
238-
return newTransportAdapter("tcp", as.logger, as).handleTCPStream(frame, carryover)
239-
}
240-
241237
func (as *AuditServer) executor() ruleGroupExecutor {
242238
if as.ruleExecutor.groups != nil {
243239
return as.ruleExecutor

pkg/auditserver/server_test.go

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,36 +1630,6 @@ func TestRuleGroup_shouldLog_RuntimeErrorContinues(t *testing.T) {
16301630
assert.True(t, rg.shouldLog(&AuditLog{}))
16311631
}
16321632

1633-
func TestAuditServer_HandleTCPStream(t *testing.T) {
1634-
logger := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{Level: slog.LevelDebug}))
1635-
writer := new(bytes.Buffer)
1636-
1637-
as := &AuditServer{
1638-
logger: logger,
1639-
ruleGroups: []RuleGroup{
1640-
{Name: "default", Writer: writer},
1641-
},
1642-
}
1643-
1644-
stream := []byte(string(auditFrame()) + "\n" + string(auditFrame()) + "\r\n")
1645-
remaining := as.handleTCPStream(stream, nil)
1646-
require.Empty(t, remaining)
1647-
1648-
frameText := string(auditFrame())
1649-
assert.Equal(t, 2, strings.Count(writer.String(), frameText))
1650-
1651-
// split frame across reads and validate carryover behavior
1652-
full := string(auditFrame())
1653-
mid := len(full) / 2
1654-
carry := as.handleTCPStream([]byte(full[:mid]), nil)
1655-
require.NotEmpty(t, carry)
1656-
1657-
carry = as.handleTCPStream([]byte(full[mid:]+"\n"), carry)
1658-
require.Empty(t, carry)
1659-
1660-
assert.Equal(t, 3, strings.Count(writer.String(), frameText))
1661-
}
1662-
16631633
func TestNew_AuditTransportConfiguration(t *testing.T) {
16641634
server, err := New(nil)
16651635
require.NoError(t, err)

0 commit comments

Comments
 (0)