Skip to content

Commit 0cb3061

Browse files
committed
Restructure linkcheck matrix per review
1 parent b5c65a8 commit 0cb3061

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/test.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,18 @@ jobs:
2525
if: ${{ github.repository_owner == 'pypa' || github.event_name != 'schedule' }}
2626
runs-on: ubuntu-latest
2727
timeout-minutes: 20
28-
# Don't block PRs on linkcheck unrelated failures
29-
continue-on-error: ${{ matrix.ignore-errors || false }}
28+
continue-on-error: >-
29+
${{ fromJSON(matrix.continue-on-error) }}
3030
strategy:
31-
fail-fast: false
3231
matrix:
3332
noxenv:
3433
- build
35-
- linkcheck
34+
continue-on-error:
35+
- false
3636
include:
3737
- noxenv: linkcheck
38-
ignore-errors: true
38+
continue-on-error: >- # Don't block PRs on linkcheck unrelated failures
39+
${{ toJSON(github.event_name == 'pull_request') }}
3940
4041
steps:
4142
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

0 commit comments

Comments
 (0)