Feature/add gc bias optimize#283
Merged
Merged
Conversation
Citations and JOSS paper
Collaborator
Author
|
@keshav-gandhi Added GC bias, which required refactoring the cover_dataset function a bit. Also added a bunch of tests. If you can run a few of your own tests when you have time and confirm coverage is working as expected, that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding GC bias into the NEAT codebase. This required refactoring how we cover the datasets as well. It is now more similar to the algorithm used by rusty-neat, which should be better at avoiding infinite loops. Added some gitnexus-generated helpers as well.