Drop cleanup_splits and reuse_splits; bump to v4.5.1#300
Merged
Conversation
reuse_splits was broken (raised unconditionally regardless of whether the splits dir existed). cleanup_splits existed only to support it. Splits always go in the TemporaryDirectory that auto-cleans on exit. Both keys added to DEPRECATED_KEYS so old configs warn instead of silently no-oping. README examples, test fixtures, and test_options updated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
reuse_splits was broken (raised unconditionally regardless of whether the splits dir existed). cleanup_splits existed only to support it. Splits always go in the TemporaryDirectory that auto-cleans on exit. Both keys added to DEPRECATED_KEYS so old configs warn instead of silently no-oping. README examples, test fixtures, and test_options updated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reuse_splits was broken (raised unconditionally regardless of whether the splits dir existed). cleanup_splits existed only to support it. Splits always go in the TemporaryDirectory that auto-cleans on exit.
Both keys added to DEPRECATED_KEYS so old configs warn instead of silently no-oping. README examples, test fixtures, and test_options updated.