Added uncaught exception handler

Author: ndahn

hkb_editor/gui/beh_editor.py

@@ -277,12 +277,6 @@ def _do_load_from_file(self, file_path: str):
             self._set_menus_enabled(True)
 
             dpg.focus_item(f"{self.tag}_roots_filter")
-        except Exception as e:
-            details = traceback.format_exception_only(e)
-            self.logger.error(
-                f"Loading behavior failed: {details[0]}\nSee log for details!"
-            )
-            raise e
         finally:
             dpg.delete_item(loading_screen)
 
@@ -328,7 +322,7 @@ def _locate_witchy(self) -> str:
                 title="Locate WitchyBND.exe", filetypes={"WitchyBND": "WitchyBND.exe"}
             )
             if not witchy_exe:
-                self.logger.error("WitchyBND is required for repacking behavior")
+                raise RuntimeError("WitchyBND is required for repacking behavior")
 
             self.config.witchy_exe = witchy_exe
             self.config.save()
@@ -341,7 +335,7 @@ def _locate_hklib(self) -> str:
                 title="Locate HKLib.exe", filetypes={"HKLib": "HKLib.CLI.exe"}
             )
             if not hklib_exe:
-                self.logger.error("HKLib is required for repacking behavior")
+                raise RuntimeError("HKLib is required for repacking behavior")
 
             self.config.hklib_exe = hklib_exe
             self.config.save()
@@ -362,13 +356,9 @@ def _reload_character(self) -> None:
                     game_config = detect_game_config()
                     self.chr_reloader = ChrReloader(game_config)
                 else:
-                    self.logger.error("ChrReloader is not available")
-                    return
+                    raise RuntimeError("ChrReloader is not available")
 
             self.chr_reloader.reload_character(chr)
-        except Exception as e:
-            self.logger.error(f"Reloading {chr} failed: {e}")
-            self.chr_reloader = None
         finally:
             dpg.delete_item(loading)
             self._busy = False
@@ -2163,25 +2153,22 @@ def load_bone_names(self) -> None:
         if not file_path:
             return
 
-        try:
-            self.logger.info("Loading bone names from %s", file_path)
+        self.logger.info("Loading bone names from %s", file_path)
 
-            bones = load_skeleton_bones(file_path)
-            self.loaded_skeleton_path = file_path
+        bones = load_skeleton_bones(file_path)
+        self.loaded_skeleton_path = file_path
 
-            boneweights_type_id = self.beh.type_registry.find_first_type_by_name(
-                "hkbBoneWeightArray"
-            )
-            basepath = "boneWeights"
-            aliases = AliasMap()
+        boneweights_type_id = self.beh.type_registry.find_first_type_by_name(
+            "hkbBoneWeightArray"
+        )
+        basepath = "boneWeights"
+        aliases = AliasMap()
 
-            for idx, bone in enumerate(bones):
-                aliases.add(bone, f"{basepath}:{idx}", boneweights_type_id, None)
+        for idx, bone in enumerate(bones):
+            aliases.add(bone, f"{basepath}:{idx}", boneweights_type_id, None)
 
-            # Insert left so that these aliases take priority
-            self.alias_manager.aliases.insert(0, aliases)
-        except ValueError as e:
-            self.logger.error("Loading bone names failed: %s", e, exc_info=True)
+        # Insert left so that these aliases take priority
+        self.alias_manager.aliases.insert(0, aliases)
 
     def open_fix_common_problems_dialog(self):
         tag = f"{self.tag}_fix_common_problems"

hkb_editor/gui/widgets/attributes_widget.py

@@ -1139,43 +1139,39 @@ def _update_attribute(
             self._on_value_changed(sender, handler, (old_value, new_value))
 
         if sender and dpg.does_item_exist(sender):
-            try:
-                todo = [sender]
-                while todo:
-                    widget = todo.pop()
-                    if not dpg.does_item_exist(widget):
-                        continue
-
-                    dpg_type = dpg.get_item_type(widget)
-                    if (
-                        dpg_type
-                        in (
-                            "mvAppItemType::mvInputText",
-                            "mvAppItemType::mvInputInt",
-                            "mvAppItemType::mvInputFloat",
-                            "mvAppItemType::mvInputDouble",
-                            "mvAppItemType::mvCheckbox",
-                            "mvAppItemType::mvCombo",
-                        )
-                        and dpg.is_item_visible(widget)
-                        and "bindable_attribute" not in dpg.get_item_alias(widget)
-                    ):
-                        if dpg_type == "mvAppItemType::mvCombo":
-                            items: list[str] = dpg.get_item_configuration(widget)[
-                                "items"
-                            ]
-                            if isinstance(ui_repr, int):
-                                ui_repr = items[ui_repr]
-                            else:
-                                ui_repr = items.index(str(ui_repr))
-
-                        dpg.set_value(widget, ui_repr)
-                        break
-                    else:
-                        todo.extend(dpg.get_item_children(widget, 1))
-            except Exception as e:
-                self.logger.error(f"dpg.set_value failed: {e}")
-                raise e
+            todo = [sender]
+            while todo:
+                widget = todo.pop()
+                if not dpg.does_item_exist(widget):
+                    continue
+
+                dpg_type = dpg.get_item_type(widget)
+                if (
+                    dpg_type
+                    in (
+                        "mvAppItemType::mvInputText",
+                        "mvAppItemType::mvInputInt",
+                        "mvAppItemType::mvInputFloat",
+                        "mvAppItemType::mvInputDouble",
+                        "mvAppItemType::mvCheckbox",
+                        "mvAppItemType::mvCombo",
+                    )
+                    and dpg.is_item_visible(widget)
+                    and "bindable_attribute" not in dpg.get_item_alias(widget)
+                ):
+                    if dpg_type == "mvAppItemType::mvCombo":
+                        items: list[str] = dpg.get_item_configuration(widget)[
+                            "items"
+                        ]
+                        if isinstance(ui_repr, int):
+                            ui_repr = items[ui_repr]
+                        else:
+                            ui_repr = items.index(str(ui_repr))
+
+                    dpg.set_value(widget, ui_repr)
+                    break
+                else:
+                    todo.extend(dpg.get_item_children(widget, 1))
 
     def _cut_value(self, sender: str, app_data: Any, user_data: Any) -> None:
         # deselect the selectable
@@ -1185,13 +1181,7 @@ def _cut_value(self, sender: str, app_data: Any, user_data: Any) -> None:
         widget = self._selected_attribute_info.widget
         val = dpg.get_value(widget)
 
-        try:
-            pyperclip.copy(str(val))
-        except pyperclip.PyperclipException as e:
-            self.logger.error("Cut value failed: %s", e)
-            # Not nice, but clearing the value without having copied it is worse
-            return
-
+        pyperclip.copy(str(val))
         default_val = type(val)()
         self._update_attribute(widget, default_val, attribute)
 
@@ -1241,13 +1231,10 @@ def _paste_value(self, sender: str) -> None:
                 new_value = data
 
             # Let the handler handle the rest
-            try:
-                self._update_attribute(widget, new_value, attribute)
+            self._update_attribute(widget, new_value, attribute)
 
-                if isinstance(attribute, HkbPointer) and self._on_graph_changed:
-                    self._on_graph_changed()
-            except Exception as e:
-                self.logger.error(f"Paste value to {path} failed: {e}")
+            if isinstance(attribute, HkbPointer) and self._on_graph_changed:
+                self._on_graph_changed()
 
     def _move_array_item(self, sender: str, offset: int) -> None:
         # deselect the selectable

hkb_editor/gui/workflows/apply_template.py

@@ -134,11 +134,8 @@ def on_okay() -> None:
 
             # Undo any changes that might have already happened
             if prev_undo != behavior.top_undo_id():
-                try:
-                    behavior.undo()
-                    logger.warning("All recorded changes undone")
-                except Exception as e:
-                    logger.error(f"Some of the changes the failed template made could not be undone: {e}")
+                behavior.undo()
+                logger.warning("All recorded changes undone")
 
         else:
             logger.info(f"Template '{template._title}' finished successfully")

hkb_editor/gui/workflows/clone_hierarchy.py

@@ -227,8 +227,8 @@ def import_hierarchy(
     def resolve_root_path(root_path: list[str]) -> HkbPointer:
         try:
             target_obj = behavior.resolve_unique_object_path(root_path[:-1])
-        except Exception:
-            logger.error(f"Failed to resolve root path {root_path}", exc_info=True)
+        except Exception as e:
+            logger.error(f"Failed to resolve root path {root_path}", exc_info=e)
             return None
 
         # Check if the last path component went into a pointer array. If so, append

main.py

@@ -24,12 +24,13 @@ def main():
     )
     _logger = logging.getLogger(__name__)
 
-    # TODO use this and remove redundant logging
-    # def handle_uncaught(exc_type, exc_value, exc_traceback):
-    #     sys.__excepthook__(exc_type, exc_value, exc_traceback)
-    #     _logger.error(str(exc_value))
+    # Handle uncaught exceptions
+    def handle_uncaught(exc_type, exc_value, exc_traceback):
+        if exc_type is not KeyboardInterrupt:
+            _logger.error(str(exc_value), exc_info=exc_value)
+        sys.__excepthook__(exc_type, exc_value, exc_traceback)
 
-    # sys.excepthook = handle_uncaught
+    sys.excepthook = handle_uncaught
 
     # Check for clipboard support, will print instructions if it fails
     try: