Add containers group for redundant toList hints (fixes #1570)#1689
Open
mgajda wants to merge 1 commit intondmitchell:masterfrom
Open
Add containers group for redundant toList hints (fixes #1570)#1689mgajda wants to merge 1 commit intondmitchell:masterfrom
mgajda wants to merge 1 commit intondmitchell:masterfrom
Conversation
…1570) New hint group `containers` with rewrites that bypass the intermediate list produced by `Data.IntMap.toList`, `Data.IntSet.toList`, `Data.Map.toList` and `Data.Set.toList` in favour of the container's own fold and predicate primitives. Adds a matching `package: containers` declaration so the group's `imports:` can reference it. All rewrite targets are fully qualified (`Data.Map.null`, `Data.IntSet.member`, etc.), so the group is safe to enable by default: it only fires when the qualified containers API is already in use.
mgajda
force-pushed
the
fix/containers-tolist
branch
from
4e09bde to
f33b6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1570. Adds a new hint group
containerswith rewrites that skipredundant
toListcalls fromData.IntMap,Data.IntSet,Data.Mapand
Data.Set:null (Data.Map.toList x)→Data.Map.null xlength (Data.IntMap.toList x)→Data.IntMap.size xfoldMap f (Data.Map.toList x)→Data.Map.foldMapWithKey (curry f) xelem y (Data.Set.toList x)→Data.Set.member y xAll rewrite targets are fully qualified, so the group is safe to enable
by default — it only fires when the qualified containers API is already
in use.