Skip to content

Add containers group for redundant toList hints (fixes #1570) #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgajda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add containers group for redundant toList hints (fixes #1570) #1689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions data/hlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,18 @@
modules:
- import CodeWorld

- package:
name: containers
modules:
- import Data.IntMap
- import Data.IntMap.Lazy
- import Data.IntMap.Strict
- import Data.IntSet
- import Data.Map
- import Data.Map.Lazy
- import Data.Map.Strict
- import Data.Set

- group:
name: default
enabled: true
Expand Down Expand Up @@ -1133,6 +1145,43 @@
rules:
- hint: {lhs: "TH.varE 'a", rhs: "[|a|]", name: Use TH quotation brackets}

- group:
name: containers
enabled: true
imports:
- package base
- package containers
rules:
- warn: {lhs: foldMap f (Data.IntMap.toList x), rhs: Data.IntMap.foldMapWithKey (curry f) x}
- warn: {lhs: foldr f z (Data.IntMap.toList x), rhs: Data.IntMap.foldrWithKey (curry f) z x}
- warn: {lhs: foldr' f z (Data.IntMap.toList x), rhs: Data.IntMap.foldrWithKey' (curry f) z x}
- warn: {lhs: foldl f z (Data.IntMap.toList x), rhs: Data.IntMap.foldlWithKey (curry . f) z x}
- warn: {lhs: foldl' f z (Data.IntMap.toList x), rhs: Data.IntMap.foldlWithKey' (curry . f) z x}
- warn: {lhs: null (Data.IntMap.toList x), rhs: Data.IntMap.null x}
- warn: {lhs: length (Data.IntMap.toList x), rhs: Data.IntMap.size x}

- warn: {lhs: foldr f z (Data.IntSet.toList x), rhs: Data.IntSet.foldr f z x}
- warn: {lhs: foldr' f z (Data.IntSet.toList x), rhs: Data.IntSet.foldr' f z x}
- warn: {lhs: foldl f z (Data.IntSet.toList x), rhs: Data.IntSet.foldl f z x}
- warn: {lhs: foldl' f z (Data.IntSet.toList x), rhs: Data.IntSet.foldl' f z x}
- warn: {lhs: null (Data.IntSet.toList x), rhs: Data.IntSet.null x}
- warn: {lhs: length (Data.IntSet.toList x), rhs: Data.IntSet.size x}
- warn: {lhs: elem y (Data.IntSet.toList x), rhs: Data.IntSet.member y x}
- warn: {lhs: notElem y (Data.IntSet.toList x), rhs: Data.IntSet.notMember y x}

- warn: {lhs: foldMap f (Data.Map.toList x), rhs: Data.Map.foldMapWithKey (curry f) x}
- warn: {lhs: foldr f z (Data.Map.toList x), rhs: Data.Map.foldrWithKey (curry f) z x}
- warn: {lhs: foldr' f z (Data.Map.toList x), rhs: Data.Map.foldrWithKey' (curry f) z x}
- warn: {lhs: foldl f z (Data.Map.toList x), rhs: Data.Map.foldlWithKey (curry . f) z x}
- warn: {lhs: foldl' f z (Data.Map.toList x), rhs: Data.Map.foldlWithKey' (curry . f) z x}
- warn: {lhs: null (Data.Map.toList x), rhs: Data.Map.null x}
- warn: {lhs: length (Data.Map.toList x), rhs: Data.Map.size x}

- warn: {lhs: null (Data.Set.toList x), rhs: Data.Set.null x}
- warn: {lhs: length (Data.Set.toList x), rhs: Data.Set.size x}
- warn: {lhs: elem y (Data.Set.toList x), rhs: Data.Set.member y x}
- warn: {lhs: notElem y (Data.Set.toList x), rhs: Data.Set.notMember y x}

- group:
name: attoparsec
enabled: true
Expand Down