Skip to content

Commit 4bbb78b

Browse files
committed
chore: convert the knip config to jsonc with rationale comments
Review asked for inline explanations of the @openai/codex exclusion and the warn-level rule strategy; plain JSON cannot carry comments, so the config becomes knip.jsonc (a format knip resolves natively) with both rationales documented in place. https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB
1 parent e1fa83f commit 4bbb78b

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

knip.json renamed to knip.jsonc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,17 @@
2929
"where"
3030
],
3131
"ignoreDependencies": [
32+
// Editor-only LSP tooling; never imported.
3233
"typescript-language-server",
34+
// The official Codex CLI this package wraps: resolved from the HOST
35+
// install at runtime (scripts/codex-bin-resolver.js), deliberately not
36+
// a package.json dependency.
3337
"@openai/codex"
3438
],
39+
// Export/type-level findings are warn-only on purpose: the blocking signal
40+
// is unused FILES and DEPENDENCIES. The export backlog was cleared
41+
// incrementally (PRs #556/#557, down to two documented keepers); escalate a
42+
// rule to "error" once its warning count is intentionally pinned at zero.
3543
"rules": {
3644
"exports": "warn",
3745
"types": "warn",

0 commit comments

Comments
 (0)