test(settings): cover remaining experimental hotkeys

Author: ndycode

lib/codex-manager/settings-hub.ts

@@ -300,14 +300,14 @@ function getExperimentalSelectOptions(
 function mapExperimentalMenuHotkey(
 	raw: string,
 ): ExperimentalSettingsAction | undefined {
-	const lower = raw.toLowerCase();
-	if (lower === "q") return { type: "back" };
-	if (lower === "s") return { type: "save" };
 	if (raw === "1") return { type: "sync" };
 	if (raw === "2") return { type: "backup" };
 	if (raw === "3") return { type: "toggle-refresh-guardian" };
 	if (raw === "[" || raw === "-") return { type: "decrease-refresh-interval" };
 	if (raw === "]" || raw === "+") return { type: "increase-refresh-interval" };
+	const lower = raw.toLowerCase();
+	if (lower === "q") return { type: "back" };
+	if (lower === "s") return { type: "save" };
 	return undefined;
 }
 
@@ -1315,6 +1315,8 @@ const __testOnly = {
 	cloneDashboardSettings,
 	withQueuedRetry: withQueuedRetryForTests,
 	loadExperimentalSyncTarget,
+	mapExperimentalMenuHotkey,
+	mapExperimentalStatusHotkey,
 	promptExperimentalSettings,
 	persistDashboardSettingsSelection: persistDashboardSettingsSelectionForTests,
 	persistBackendConfigSelection: persistBackendConfigSelectionForTests,

test/codex-manager-cli.test.ts

@@ -4557,8 +4557,8 @@ describe("codex manager cli commands", () => {
 		const selectSequence = queueSettingsSelectSequence([
 			{ type: "experimental" },
 			requireSettingsHotkey("1", { type: "sync" }),
-			requireSettingsHotkey("a", { type: "apply" }),
-			requireSettingsHotkey("q", { type: "back" }),
+			requireSettingsHotkey("A", { type: "apply" }),
+			requireSettingsHotkey("Q", { type: "back" }),
 			{ type: "back" },
 			{ type: "back" },
 		]);
@@ -4631,7 +4631,7 @@ describe("codex manager cli commands", () => {
 		const selectSequence = queueSettingsSelectSequence([
 			{ type: "experimental" },
 			requireSettingsHotkey("2", { type: "backup" }),
-			requireSettingsHotkey("q", { type: "back" }),
+			requireSettingsHotkey("Q", { type: "back" }),
 			{ type: "back" },
 			{ type: "back" },
 		]);
@@ -4700,13 +4700,19 @@ describe("codex manager cli commands", () => {
 		const now = Date.now();
 		setupInteractiveSettingsLogin(createSettingsStorage(now));
 		const configModule = await import("../lib/config.js");
-		const defaults = configModule.getDefaultPluginConfig();
+		const defaults = {
+			...configModule.getDefaultPluginConfig(),
+			proactiveRefreshGuardian: false,
+			proactiveRefreshIntervalMs: 180_000,
+		};
 		loadPluginConfigMock.mockReturnValue(structuredClone(defaults));
 		const selectSequence = queueSettingsSelectSequence([
 			{ type: "experimental" },
 			requireSettingsHotkey("3", { type: "toggle-refresh-guardian" }),
-			requireSettingsHotkey("]", { type: "increase-refresh-interval" }),
-			requireSettingsHotkey("s", { type: "save" }),
+			requireSettingsHotkey("[", { type: "decrease-refresh-interval" }),
+			requireSettingsHotkey("-", { type: "decrease-refresh-interval" }),
+			requireSettingsHotkey("+", { type: "increase-refresh-interval" }),
+			requireSettingsHotkey("S", { type: "save" }),
 			{ type: "back" },
 		]);
 
@@ -4718,8 +4724,7 @@ describe("codex manager cli commands", () => {
 		expect(savePluginConfigMock).toHaveBeenCalledWith(
 			expect.objectContaining({
 				proactiveRefreshGuardian: !(defaults.proactiveRefreshGuardian ?? false),
-				proactiveRefreshIntervalMs:
-					(defaults.proactiveRefreshIntervalMs ?? 60000) + 60000,
+				proactiveRefreshIntervalMs: 120_000,
 			}),
 		);
 	});
@@ -4745,7 +4750,7 @@ describe("codex manager cli commands", () => {
 		const selectSequence = queueSettingsSelectSequence([
 			{ type: "experimental" },
 			{ type: "sync" },
-			requireSettingsHotkey("q", { type: "back" }),
+			requireSettingsHotkey("Q", { type: "back" }),
 			{ type: "back" },
 			{ type: "back" },
 		]);
@@ -4798,7 +4803,7 @@ describe("codex manager cli commands", () => {
 		const selectSequence = queueSettingsSelectSequence([
 			{ type: "experimental" },
 			requireSettingsHotkey("1", { type: "sync" }),
-			requireSettingsHotkey("q", { type: "back" }),
+			requireSettingsHotkey("Q", { type: "back" }),
 			{ type: "back" },
 			{ type: "back" },
 		]);

test/settings-hub-utils.test.ts

@@ -71,6 +71,8 @@ type SettingsHubTestApi = {
 	promptExperimentalSettings: (
 		initial: PluginConfig,
 	) => Promise<PluginConfig | null>;
+	mapExperimentalMenuHotkey: (raw: string) => unknown;
+	mapExperimentalStatusHotkey: (raw: string) => unknown;
 };
 
 type UiRuntimeOptions = ReturnType<typeof getUiRuntimeOptions>;
@@ -120,10 +122,10 @@ function queueSelectResults(...results: unknown[]): void {
 
 function triggerSettingsHubHotkey(
 	raw: string,
-	fallback: unknown = { type: "back" },
+	fallback: unknown = null,
 ): (items: MenuItem<unknown>[], options: unknown) => unknown {
-	return (items, options) =>
-		(options as {
+	return (items, options) => {
+		const onInput = (options as {
 			onInput?: (
 				input: string,
 				context: {
@@ -132,11 +134,14 @@ function triggerSettingsHubHotkey(
 					requestRerender: () => void;
 				},
 			) => unknown;
-		})?.onInput?.(raw, {
+		})?.onInput;
+		expect(onInput).toBeTypeOf("function");
+		return onInput?.(raw, {
 			cursor: 0,
 			items,
 			requestRerender: () => undefined,
 		}) ?? fallback;
+	};
 }
 
 vi.mock("../lib/ui/select.js", async () => {
@@ -730,19 +735,31 @@ describe("settings-hub utility coverage", () => {
 		it("supports alternate experimental interval hotkeys with minus and plus", async () => {
 			const api = await loadSettingsHubTestApi();
 			queueSelectResults(
+				triggerSettingsHubHotkey("["),
 				triggerSettingsHubHotkey("-"),
 				triggerSettingsHubHotkey("+"),
-				triggerSettingsHubHotkey("s", { type: "save" }),
+				triggerSettingsHubHotkey("S", { type: "save" }),
 			);
 			const selected = await api.promptExperimentalSettings({
-				proactiveRefreshIntervalMs: 120_000,
+				proactiveRefreshIntervalMs: 180_000,
 			});
 			expect(selected?.proactiveRefreshIntervalMs).toBe(120_000);
 		});
 
+		it("maps experimental menu and status hotkeys including numeric and uppercase variants", async () => {
+			const api = await loadSettingsHubTestApi();
+			expect(api.mapExperimentalMenuHotkey("1")).toEqual({ type: "sync" });
+			expect(api.mapExperimentalMenuHotkey("2")).toEqual({ type: "backup" });
+			expect(api.mapExperimentalMenuHotkey("[")).toEqual({
+				type: "decrease-refresh-interval",
+			});
+			expect(api.mapExperimentalMenuHotkey("S")).toEqual({ type: "save" });
+			expect(api.mapExperimentalStatusHotkey("Q")).toEqual({ type: "back" });
+		});
+
 		it("supports q hotkey to back out of experimental menu without saving", async () => {
 			const api = await loadSettingsHubTestApi();
-			queueSelectResults(triggerSettingsHubHotkey("q", { type: "back" }));
+			queueSelectResults(triggerSettingsHubHotkey("Q", { type: "back" }));
 			const selected = await api.promptExperimentalSettings({
 				proactiveRefreshGuardian: true,
 				proactiveRefreshIntervalMs: 120_000,