chore: drop unused @fast-check/vitest devDependency#581
Conversation
Nothing imports it: the property suites use plain fast-check (fc.assert / fc.asyncProperty) with explicit vitest imports per repo convention, so the @fast-check/vitest test.prop wrapper has no consumers. Plain fast-check stays. https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Warning Review limit reached
More reviews will be available in 1 minute and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
@fast-check/vitestdevDependency. Nothing in the repository imports it — the only references anywhere are thepackage.jsonentry, its lockfile subtree, and a line in the historical audit evidence snapshot.What Changed
npm uninstall @fast-check/vitest: one line out ofdevDependencies, 63 lines out ofpackage-lock.json.fast-checkstays: the property suites (test: property-check the unsupported-model fallback invariants #574, test: property-check write-queue serialization and clamp invariants #575, fix: deduplicateAccounts fixpoint loop and identity property tests #579) deliberately usefc.assert/fc.asyncPropertywith explicit vitest imports per repo convention, so thetest.propwrapper this package provides has no consumers.typescript-language-server(the other knip-flagged devDependency) was deliberately left alone — editor/LSP tooling usage is invisible to import scans, so that removal is a maintainer call.Validation
npm run typecheckafter the uninstalltest/settings-panels.test.ts) confirms the install is healthygrep -r "@fast-check/vitest"across the repo (excludingnode_modules/dist): onlypackage.json/lockfile and the frozen audit evidence fileDocs and Governance Checklist
Risk and Rollback
npm install -D @fast-check/vitestrestores it.Additional Notes
test.propAPI, reinstalling is a one-liner; until then the dependency is pure surface.https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB
Generated by Claude Code
note: greptile review for oc-chatgpt-multi-auth. cite files like
lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.Greptile Summary
removes the unused
@fast-check/vitestdevdependency frompackage.jsonand its lockfile subtree. plainfast-checkis retained since the property test suites usefc.assert/fc.asyncPropertydirectly with explicit vitest imports.package.json: one-line removal of@fast-check/vitest: ^0.2.4from devdependencies;fast-checkstays.package-lock.json:@fast-check/vitestblock removed cleanly; a side effect strips thelibcfield from ~12@rollup/rollup-linux-*optional platform packages, likely due to npm version differences during lockfile regeneration.Confidence Score: 4/5
safe to merge — removing an unused devdependency with no runtime or published-package impact.
the
@fast-check/vitestremoval is clean and well-validated. the only notable artifact is the collateral stripping oflibcfields from rollup's linux platform packages, an unintended lockfile diff from npm version drift; those packages are optional so the install won't break, but musl-based ci runners could silently fall back to the wasm rollup.package-lock.json deserves a quick look for the rollup libc field removals beyond the intended @fast-check/vitest subtree.
Important Files Changed
@fast-check/vitestfrom devDependencies — clean, no consumers in the codebase@fast-check/vitestlockfile subtree cleanly; also stripslibcfield from rollup linux platform packages as an unintended side effect of npm version differencesFlowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[npm uninstall @fast-check/vitest] --> B[package.json: remove entry] A --> C[package-lock.json: remove @fast-check/vitest block] C --> D[expected: fast-check peer dep subtree removed] C --> E[unexpected side effect: libc field stripped from @rollup/rollup-linux-* optionals] E --> F{impact?} F -->|glibc linux / macOS / windows| G[no impact - libc not used] F -->|musl linux / Alpine CI| H[npm falls back to wasm rollup - slower builds only]Comments Outside Diff (1)
package-lock.json, line 951-1124 (link)libcfield removals from rollup platform packagesthe uninstall also stripped the
libcfield from ~12@rollup/rollup-linux-*entries (bothglibcandmuslvariants for arm, arm64, loong64, ppc64, riscv64, s390x, x64). this suggests the lockfile was regenerated with a different npm version than the one that originally wrote it — thelibcfield is used by npm to select the correct native binary on linux. since these packages areoptional: trueand their names already encode the variant (-gnuvs-musl), practical impact is low. on an alpine/musl ci runner the wrong binary could theoretically be selected, falling back to the wasm rollup, which just makes builds slower. worth noting the npm version in use if this diff looks unexpected.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: drop unused @fast-check/vitest de..." | Re-trigger Greptile