fix: harden gpt-5.4 matching and close review gaps

- make gpt-5.4/pro family matching boundary-aware in runtime + prompt family detection
- clarify docs for none->low coercion across codex/pro families
- add regression tests for gpt-5.40/gpt-5.4pro non-matches and gpt-5.4-pro-none coverage

Author: ndycode

docs/configuration.md

@@ -48,7 +48,7 @@ controls how much thinking the model does.
 the shipped config templates include 21 presets and do not add optional IDs by default. add `gpt-5.4-pro` and/or `gpt-5.3-codex-spark` manually only for entitled workspaces.
 
 what they mean:
-- `none` - no reasoning phase (base models only, auto-converts to `low` for codex)
+- `none` - no reasoning phase (base models only; auto-converts to `low` for codex/pro families, including `gpt-5-codex` and `gpt-5.4-pro`)
 - `low` - light reasoning, fastest
 - `medium` - balanced (default)
 - `high` - deep reasoning

lib/prompts/codex.ts

@@ -120,7 +120,7 @@ export function getModelFamily(normalizedModel: string): ModelFamily {
 	) {
 		return "codex";
 	}
-	if (normalizedModel.includes("gpt-5.4") || normalizedModel.includes("gpt 5.4")) {
+	if (/\bgpt(?:-| )5\.4(?:\b|[- ])/i.test(normalizedModel)) {
 		return "gpt-5.4";
 	}
 	if (normalizedModel.includes("gpt-5.2")) {

lib/request/request-transformer.ts

@@ -80,15 +80,12 @@ export function normalizeModel(model: string | undefined): string {
 	}
 
 	// 4. GPT-5.4 Pro (optional/manual model)
-	if (
-		normalized.includes("gpt-5.4-pro") ||
-		normalized.includes("gpt 5.4 pro")
-	) {
+	if (/\bgpt(?:-| )5\.4(?:-| )pro(?:\b|[- ])/.test(normalized)) {
 		return "gpt-5.4-pro";
 	}
 
 	// 5. GPT-5.4 (general purpose)
-	if (normalized.includes("gpt-5.4") || normalized.includes("gpt 5.4")) {
+	if (/\bgpt(?:-| )5\.4(?:\b|[- ])/.test(normalized)) {
 		return "gpt-5.4";
 	}
 

test/codex-prompts.test.ts

@@ -84,6 +84,10 @@ describe("Codex Prompts Module", () => {
 				expect(getModelFamily("gpt 5.4 pro")).toBe("gpt-5.4");
 			});
 
+			it("should not classify gpt-5.40 style names as gpt-5.4 family", () => {
+				expect(getModelFamily("gpt-5.40")).toBe("gpt-5.1");
+			});
+
 			it("should detect gpt-5.3-codex-spark", () => {
 				expect(getModelFamily("gpt-5.3-codex-spark")).toBe("gpt-5-codex");
 			});

test/gpt54-models.test.ts

@@ -63,6 +63,7 @@ describe("GPT-5.4 Model Support", () => {
 
 		it("should normalize all gpt-5.4-pro reasoning effort variants", () => {
 			const variants = [
+				"gpt-5.4-pro-none",
 				"gpt-5.4-pro-low",
 				"gpt-5.4-pro-medium",
 				"gpt-5.4-pro-high",
@@ -93,6 +94,7 @@ describe("GPT-5.4 Model Support", () => {
 
 		it("should handle gpt-5.4-pro in MODEL_MAP", () => {
 			expect(MODEL_MAP["gpt-5.4-pro"]).toBe("gpt-5.4-pro");
+			expect(MODEL_MAP["gpt-5.4-pro-none"]).toBe("gpt-5.4-pro");
 			expect(MODEL_MAP["gpt-5.4-pro-low"]).toBe("gpt-5.4-pro");
 			expect(MODEL_MAP["gpt-5.4-pro-medium"]).toBe("gpt-5.4-pro");
 			expect(MODEL_MAP["gpt-5.4-pro-high"]).toBe("gpt-5.4-pro");
@@ -203,10 +205,10 @@ describe("GPT-5.4 Model Support", () => {
 			expect(normalizeModel("gpt_5_4")).toBe("gpt-5.1");
 		});
 
-		it("should match gpt-5.4x patterns as gpt-5.4", () => {
-			// gpt-5.40 and gpt-5.44 contain "gpt-5.4" so they match gpt-5.4 pattern
-			expect(normalizeModel("gpt-5.40")).toBe("gpt-5.4");
-			expect(normalizeModel("gpt-5.44")).toBe("gpt-5.4");
+		it("should not match gpt-5.4x patterns as gpt-5.4", () => {
+			// Boundary-aware matching prevents accidental family routing from nearby version strings.
+			expect(normalizeModel("gpt-5.40")).toBe("gpt-5.1");
+			expect(normalizeModel("gpt-5.44")).toBe("gpt-5.1");
 		});
 
 		it("should handle empty/undefined model names defaulting to gpt-5.1", () => {
@@ -283,7 +285,7 @@ describe("GPT-5.4 Model Support", () => {
 			const gpt54ProVariants = Object.keys(MODEL_MAP).filter((key) =>
 				key.startsWith("gpt-5.4-pro")
 			);
-			expect(gpt54ProVariants.length).toBeGreaterThanOrEqual(5); // base + 4 effort levels (no 'none')
+			expect(gpt54ProVariants.length).toBeGreaterThanOrEqual(6); // base + none/low/medium/high/xhigh
 		});
 
 		it("should ensure all gpt-5.4 variants map to correct normalized name", () => {
@@ -297,4 +299,4 @@ describe("GPT-5.4 Model Support", () => {
 			}
 		});
 	});
-});
+});

test/request-transformer.test.ts

@@ -156,6 +156,11 @@ describe('Request Transformer Module', () => {
 				expect(normalizeModel('GPT-5.3-CODEX-SPARK')).toBe('gpt-5-codex');
 			});
 
+			it('should not misclassify unrelated gpt-5.4x model strings', async () => {
+				expect(normalizeModel('gpt-5.40')).toBe('gpt-5.1');
+				expect(normalizeModel('gpt-5.4pro')).toBe('gpt-5.1');
+			});
+
 			it('should handle mixed case', async () => {
 				expect(normalizeModel('Gpt-5-Codex-Low')).toBe('gpt-5-codex');
 				expect(normalizeModel('GpT-5-MeDiUm')).toBe('gpt-5.1');