ci: adopt shared reusable release workflows + pin-at-release OCI publishing#139
Merged
Conversation
…_DOWNLOADER_IMAGE
…og config Replace the per-image build steps in build-images.yaml with thin caller jobs that invoke the shared nebari-dev/.github pack-build-image reusable workflow, add a release.yaml caller for pack-release, and add .github/release.yml with changelog categories keyed on this repo's labels. The @feat/pack-release-workflows ref is a bring-up ref and must be re-pinned to v1 before this PR merges.
Add charts/nebari-llm-serving/Chart.yaml to the push trigger paths in build-images.yaml so the release commit (a Chart.yaml version bump) produces sha-<commit> images before the release workflow pins the chart to that sha. Update the CI/CD docs to reflect that a release now triggers both workflows in parallel instead of describing this as a known gap.
Follows the repo rename; only the ghcr.io image paths change (the github.com repo URLs are redirect-handled and left for the repo-rename cleanup). Go module path untouched.
|
📄 Docs preview for |
Now that nebari-dev/.github#43 is merged and tagged v1, pin the caller refs to the release tag and drop the bring-up TODOs.
dcmcand
marked this pull request as ready for review
July 15, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the pack's release pipeline to the shared reusable workflows in
nebari-dev/.github(see nebari-dev/.github#43) and the pin-at-release model. Removes the three release bugs the old git-tag model had:appVersiondrift, thev-prefix image-tag mismatch, and the floatingmodel-downloader:latestinit image.Changes
LLM_MODEL_DOWNLOADER_IMAGE(defaults to the built-in constant when unset); table-driven test added..Chart.AppVersion(templates use.Values.<c>.image.tag); tags float tolatestonmainand are pinned to a build sha at release time; newmodelDownloader.imageblock wired into the operator env. Image paths updatednebari-llm-serving-pack->llm-serving-pack, following the repo rename.build-images.yamlandrelease.yamlare now thin callers of the reusable workflows;build-imagesalso runs on aChart.yamlbump so a release commit produces its images;.github/release.ymlgives categorized changelog notes.cicd-and-releasing.mdrewritten to explain the pin-at-release flow (bumpChart.yamlin a PR, merge, and the chart publishes to OCI with pinned images and generated release notes).Merge ordering (draft until then)
Depends on nebari-dev/.github#43 - that must merge and be tagged
v1first. Theuses:refs here point at the bring-up branch (@feat/pack-release-workflows) and must be re-pinned to@v1before merge; TODO comments mark all five call sites.Verification
go test,helm lint/helm template(renders the four images at the new path, model-downloader env correct, noappVersionin any tag),actionlint, and the docs build all pass locally. Live behavior (quay push, OCI publish, GitHub Release with categorized notes) is exercised on the first real run after merge.Image-path rename follow-through
The
ghcr.io/.../llm-serving-pack/...image-path rename is propagated toREADME.mdandui-development.mdin this PR.configurationandshared-storageare owned by the docs PR (#138, converted to.mdxthere), so their image paths are fixed in that PR to avoid a merge conflict.Out of scope (tracked separately)
The Go module path (
github.com/nebari-dev/nebari-llm-serving-pack/...) and thegithub.comrepo/issue URLs, which GitHub redirects handle - part of the broader repo-rename cleanup.