Add external auth contract integration#51
Open
ns-mkusper wants to merge 8 commits into
Open
Conversation
ns-mkusper
force-pushed
the
feat/external-auth-contract-consumer
branch
from
2623cf9 to
6adba36
Compare
ns-mkusper
force-pushed
the
feat/external-auth-contract-consumer
branch
from
ec3f250 to
56d5599
Compare
ns-mkusper
force-pushed
the
feat/external-auth-contract-consumer
branch
from
56d5599 to
56fc30c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the external auth consumer path to JupyterHub spawning.
When a user has linked GitHub through external-auth, new notebook servers receive
GITHUB_TOKENandGH_TOKEN. The spawn hook also configures Git at container startup so normal commands likegit clone https://github.com/openteams-ai/mystic-checkmaite-plugin-custody.gitwork without users manually editing clone URLs or adding credential helpers.The Git credential helper reads
GITHUB_TOKENat runtime and does not write the token value into git config. Existing lifecyclepostStarthooks are preserved and appended to.Validation:
python -m pytest tests/unit/test_external_auth.py -qpython -m pytest tests/unit -q