Dialog

[karamba228]

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

Documentation

Access-centered content checklist

Text styling

• The content is written with plain language (where relevant).
• If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
• All links describe where they link to (for example, check the Nebari website).
• This content adheres to the Nebari style guides.

Non-text content

• All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
• If there are emojis, there are not more than three in a row.
• Don't use flashing GIFs or videos.
• If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

[smeragoel]

Thanks @karamba228 all looks wonderful! The only comment I'd have is the dark-mode overlay scrim. The backdrop is bg-foreground/30. Since --foreground flips to zinc-50 in dark mode, the scrim becomes white 30% in dark, which fogs/lightens the background rather than dimming it. This is our first backdrop in the DS, and coincidientally, I ran into this issue earlier this week while working on some designs. I have added a new scrim variable to the design system that needs to be added to global.css, and then replaced here.

 --scrim: rgba(0, 0, 0, 0.5);   /* light */
 --scrim: rgba(0, 0, 0, 0.6);   /* dark */

[jbouder]

Seeing 1 failing test when running locally, can you take a look?

[karamba228]

Seeing 1 failing test when running locally, can you take a look?

Unable to reproduce locally, can you send a screenshot of the failing test?

[jbouder]

Seeing 1 failing test when running locally, can you take a look?

Unable to reproduce locally, can you send a screenshot of the failing test?

Looks like it went away when i did a fresh bun install