Card#97
Merged
Merged
Conversation
Closed
9 tasks
smeragoel
approved these changes
Jul 6, 2026
jbouder
requested changes
Jul 6, 2026
jbouder
left a comment
Contributor
There was a problem hiding this comment.
One minor nit...
stories/card.stories.tsx:307 — "Edge-to-edge content" story is not actually edge-to-edge at the top.
The Card root always applies py-(--card-spacing) (~20px), and the only rule that removes the top padding is has-[>img:first-child]:pt-0 (card.tsx:6), which requires the first child to be an . This story's first child is a
, not an img, so pt-0 never matches — the colored media block renders with ~20px of leftover padding above it (card background showing through), demonstrating the opposite of what the story name promises. The sibling rule *:[img:first-child]:rounded-t-md likewise doesn't fire for the div.
Fix: use an as the first child (matching how the has-[>img:first-child] rules are designed to be consumed), or add an explicit pt-0 on the story's Card.
jbouder
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?