Surfaced during review of #259 (pkg/provider/aws/aws_load_balancer_controller.go:175).
nic deploy is idempotent and re-runs the Helm upgrade for the LBC each time. The Helm Go client's upgrade action does not set MaxHistory by default, which means every nic deploy creates a new release revision and they accumulate without bound. The Helm CLI defaults this to 10.
Proposed fix
on the upgrade client. Same likely applies to any other Helm installs we drive from Go (worth a quick audit while we are in there).
Definition of done
Review thread: #259 (comment)
Surfaced during review of #259 (
pkg/provider/aws/aws_load_balancer_controller.go:175).nic deployis idempotent and re-runs the Helm upgrade for the LBC each time. The Helm Go client's upgrade action does not setMaxHistoryby default, which means everynic deploycreates a new release revision and they accumulate without bound. The Helm CLI defaults this to 10.Proposed fix
on the upgrade client. Same likely applies to any other Helm installs we drive from Go (worth a quick audit while we are in there).
Definition of done
MaxHistoryset to 10 on the LBC Helm upgrade clienthelm history -n kube-system aws-load-balancer-controllerafter multiplenic deployruns that history is boundedReview thread: #259 (comment)