Add Users and Groups permissions filters to DaskWorker profiles#2391
Open
viniciusdc wants to merge 3 commits into
Open
Add Users and Groups permissions filters to DaskWorker profiles#2391viniciusdc wants to merge 3 commits into
viniciusdc wants to merge 3 commits into
Conversation
Contributor
Author
|
A few remarks:
|
Member
|
@viniciusdc what's the status of this PR? |
Contributor
Author
|
Hi, @marcelovilla; thanks for the ping. This was ready for review back then, but there are some changes that I need to make for this work again. As you said, the first step is fixing the conflicts. |
Member
|
@viniciusdc I'll review this once you've had the change to fix the merge conflicts |
Contributor
|
@viniciusdc what is the status here? |
Contributor
Author
|
Will need to fix this during the weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
#979
What does this implement/fix?
This PR includes the ability to restrict users from selecting dask worker profiles based on two factors:
nebari-config.yamlfile:bellow an example of such an attribute for a given user:
This follows the same model that is already in place for jupyterhub profiles.
Put a
xin the boxes that applyTesting
Any other comments?