Skip to content

enhancement : Moved Docker images repo to docker folder in main branch#2932

Closed
Helion55 wants to merge 36 commits into
nebari-dev:mainfrom
Helion55:main
Closed

enhancement : Moved Docker images repo to docker folder in main branch#2932
Helion55 wants to merge 36 commits into
nebari-dev:mainfrom
Helion55:main

Conversation

@Helion55

@Helion55 Helion55 commented Feb 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Reference Issues or PRs

Fixes #2871

What does this implement/fix?

  • Other (please describe):

Moved docker-images repo back to main nebari's repo. Changes made,

  1. Created folder named docker and moved the necessary files from docker repository.
  2. Updated the .github/workflows folder by adding the build-push-docker.yaml and test-images.yaml files from docker repo's workflow folder.
  3. Added documentation.yml and RFD.md files to .github/ISSUE_TEMPLATE folder.
  4. Updated .pre-commit-config.yaml file.

Testing

  • Did you test the pull request locally?
    no
  • Did you add new tests?
    no

Any other comments?

no

@viniciusdc

viniciusdc commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Hey @Helion55 thanks for opening this PR! we will have a look during the following days, in nebari we use pre-commit to lint the files and commit changes; its just a few typos, but if you want then to be self-fixed, you can pip install pre-commit and run pre-commit install that should then run in your next commit. For now, this is the line that currently needs changes:

error: `statis` should be `stasis`, `status`
  --> docker/scripts/install-conda-environment.sh:56:29

@dcmcand dcmcand requested a review from a team as a code owner February 7, 2025 14:49
@dcmcand dcmcand requested review from dcmcand and marcelovilla and removed request for a team February 7, 2025 14:49
@viniciusdc

viniciusdc commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Hey, @ Helion55, I am giving you a heads-up on the review status. We are finishing the latest release of Nebari. Once that's out,, we will include this PR on our discussion board next week. Once again, thanks for opening the PR!

@Helion55

Helion55 commented Feb 17, 2025

Copy link
Copy Markdown
Author

Thanks @viniciusdc, I was curious about it. I have fixed the thing that you had mentioned. Waiting to catch up on next week.

github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 20, 2025
View reviewed changes
Comment thread docker/Dockerfile.dask-worker Outdated
@@ -0,0 +1,41 @@
# Copyright (c) Nebari Development Team.

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: docker/Dockerfile.dask-worker Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
Comment thread docker/Dockerfile.dask-worker Outdated
@@ -0,0 +1,41 @@
# Copyright (c) Nebari Development Team.

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: docker/Dockerfile.dask-worker Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
Comment thread docker/Dockerfile.jupyterhub Outdated
@@ -0,0 +1,41 @@
# Copyright (c) Nebari Development Team.

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: docker/Dockerfile.jupyterhub Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
Comment thread docker/Dockerfile.jupyterhub Outdated
@@ -0,0 +1,41 @@
# Copyright (c) Nebari Development Team.

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: docker/Dockerfile.jupyterhub Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
Comment thread docker/Dockerfile.jupyterlab Outdated
@@ -0,0 +1,70 @@
# Copyright (c) Nebari Development Team.

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: docker/Dockerfile.jupyterlab Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
Comment thread docker/Dockerfile.jupyterlab Outdated
@@ -0,0 +1,70 @@
# Copyright (c) Nebari Development Team.

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: docker/Dockerfile.jupyterlab Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
Comment thread docker/Dockerfile.workflow-controller Outdated
@@ -0,0 +1,61 @@
# Copyright (c) Nebari Development Team.

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: docker/Dockerfile.workflow-controller Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
Comment thread docker/Dockerfile.workflow-controller Outdated
@@ -0,0 +1,61 @@
# Copyright (c) Nebari Development Team.

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: docker/Dockerfile.workflow-controller Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
@viniciusdc

viniciusdc commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Will start looking into it today

@viniciusdc viniciusdc added the status: in review 👀 This PR is currently being reviewed by the team label Feb 25, 2025
@dcmcand dcmcand requested a review from viniciusdc March 6, 2025 12:09
@dcmcand dcmcand moved this from New 🚦 to In review/QA 👀 in 🪴 Nebari Project Management Mar 6, 2025
@viniciusdc

viniciusdc commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Hey @Helion55, I did a quick look at your PR. Since this will be an initial part of a big file move, I would like to disable or not copy the action files initially. Also, we will be making some changes this week in that repo to make things faster to build and more stable overall, so you will probably need to copy/modify the files again.

In the meantime, to not leave you empty-handed, feel free to check any of our issues with Help Needed to Good First Issue labels.

@Helion55

Helion55 commented Mar 18, 2025

Copy link
Copy Markdown
Author

Thanks @viniciusdc, Sure, I will do that.

@marcelovilla marcelovilla moved this from In review/QA 👀 to TODO 📬 in 🪴 Nebari Project Management Mar 20, 2025
@Helion55

Helion55 commented Apr 23, 2025

Copy link
Copy Markdown
Author

Hello, I have removed those two workflow files; kindly check the PR now. And I apologize for my delayed activity.

@viniciusdc

viniciusdc commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Hey @Helion55 sorry I missed your message, thanks. I will need to have a look at this later on...though you might need to copy the files again since a lot has changed in that repo since then

@Helion55

Helion55 commented Jun 14, 2025

Copy link
Copy Markdown
Author

Sure @viniciusdc . I'll check and copy them.

Helion55 added 19 commits June 20, 2025 17:56
@Helion55
Delete docker/jupyterlab/apt.txt
740ecbe
@Helion55
Upgrade JupyterHub to 5.3.0
8bd4511
@Helion55
Delete docker/nebari-workflow-controller/apt.txt
51ed4c2
@Helion55
Update install-code-server.sh from optimize dockerfile (#211) commit
f5d32a8
@Helion55
Update install-code-server.sh from optimize dockerfile (#211) commit
0c1bd93
@Helion55
Update install-conda.sh from optimize dockerfile (#211) commit
41e851a
@Helion55
Update install-code-server.sh from optimize dockerfile (#211) commit
82ec35a
@Helion55
Delete docker/scripts/install-apt-minimal.sh
1844d7d
@Helion55
Delete docker/scripts/install-apt.sh
d6730bf
@Helion55
Delete docker/Dockerfile.dask-worker
7ca9de4
@Helion55
Delete docker/Dockerfile.jupyterhub
d9e352f
@Helion55
Delete docker/Dockerfile.jupyterlab
686d04a
@Helion55
Delete docker/Dockerfile.workflow-controller
d2ec3ec
@Helion55
Created Dockerfile from Update base images to use Ubuntu 24.04 (#213)
02f9a79
@Helion55
Created makefile from optimize dockerfile (#211) commit
4a91c3e
@Helion55
Updated README.md from optimize dockerfile (#211) commit
5b87da4
@Helion55
Created build_push_docker.yaml from Update base images to use Ubuntu …
2457d6a 
…24.04 (#213) commit
@Helion55
Create test_images.yaml from Update base images to use Ubuntu 24.04 (#…
358c8d0 
…213) commit
@Helion55
Created docker_trivy.yaml from Set up Trivy config scanning for Docke…
f7a5650 
…rfile misconfigurations (#214) commit
@Helion55

Helion55 commented Jun 20, 2025

Copy link
Copy Markdown
Author

Hi team, I have updated the branch with the latest commits from nebari-docker-images repo. Kindly check once.

@viniciusdc

viniciusdc commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Thanks @Helion55, I will have time next week to look into this

viniciusdc
viniciusdc reviewed Jun 28, 2025
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/RFD.md Outdated
@@ -0,0 +1,52 @@
---

@viniciusdc viniciusdc Jun 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These template files are not needed

@Helion55 Helion55 Jul 4, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @viniciusdc, is it fine now?

@viniciusdc viniciusdc Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks! I need to take a closer look at what we need to do internally to make this all work from here. I haven't had the time to do so yet, but I plan to check this later today or tomorrow, or next Wednesday.

@viniciusdc

viniciusdc commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Hey @Helion55 sorry this got quite shifted, I hope to have some time to look into it this Friday

@viniciusdc

viniciusdc commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Also, I suggest you create feature branches in your Fork and create the PRs from those instead of from your main. This gets your git history clean and entirely in sync with ours.

@Helion55 Helion55 closed this by deleting the head repository Oct 30, 2025
@Helion55

Helion55 commented Oct 30, 2025

Copy link
Copy Markdown
Author

Hi @viniciusdc, Now I have created a PR for this from a separate feature branch. Kindly check once #3177.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viniciusdc viniciusdc viniciusdc left review comments
@dcmcand dcmcand Awaiting requested review from dcmcand dcmcand is a code owner automatically assigned from nebari-dev/maintenance-team
@marcelovilla marcelovilla Awaiting requested review from marcelovilla marcelovilla is a code owner automatically assigned from nebari-dev/maintenance-team

Assignees

@viniciusdc viniciusdc

Labels

status: in review 👀 This PR is currently being reviewed by the team

Projects

🪴 Nebari Project Management
Status: TODO 📬

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MAINT] - Move docker-images repo back to main nebari's repo

5 participants

@Helion55 @viniciusdc @github-advanced-security @dcmcand @marcelovilla