[ImageLoader] Simplify getSize implementation, call failure callback when decoding fails#2750
Open
lkinasiewicz wants to merge 3 commits intonecolas:masterfrom
Open
[ImageLoader] Simplify getSize implementation, call failure callback when decoding fails#2750lkinasiewicz wants to merge 3 commits intonecolas:masterfrom
lkinasiewicz wants to merge 3 commits intonecolas:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f8ddd30:
|
9339513 to
04e3092
Compare
CrashBashMD
approved these changes
Dec 30, 2024
CrashBashMD
left a comment
There was a problem hiding this comment.
looks like it was over complicated before
Fixes possible infinite intervals
04e3092 to
f8ddd30
Compare
|
I decided to fork this repo to apply the patch and make it available: https://www.npmjs.com/package/react-native-web-fork The easiest way to use it is probably this package.json override: There are other patches applied as well, noted in the package README up top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2749.
getSizeimplementation, so that there is no possibility for infinite timers.getSize.