Update dependencies and refactor PInvoke calls to use Span-based patterns#147
Conversation
📝 WalkthroughWalkthroughNuGet package versions are bumped across test frameworks, Roslyn analyzers, and Windows SDK metadata. PInvoke call sites throughout the library are refactored to use ChangesDependency Updates
Interop Boundary Refactoring
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Generator/DeviceManagementPropertiesGenerator.csproj`:
- Around line 16-25: The PackageReference for Microsoft.Windows.CsWin32 is
pinned to Version="0.3.279" which is not available on the configured NuGet
feeds; open the PackageReference element PackageReference
Include="Microsoft.Windows.CsWin32" Version="0.3.279" and update the Version
attribute to a release that exists on your feeds (check nuget.org or your winsdk
feed for the latest available 0.3.x or stable version) or add the correct feed
that hosts 0.3.279 so the project can restore successfully.
In `@src/Nefarius.Utilities.DeviceManagement.csproj`:
- Around line 29-34: The referenced Microsoft.Windows.CsWin32 version 0.3.279 in
Nefarius.Utilities.DeviceManagement.csproj and
DeviceManagementPropertiesGenerator.csproj is not available on the public NuGet
flatcontainer—validate that exact CsWin32 0.3.279 exists on the intended feed or
replace it with a published version; either point both projects to a confirmed
CsWin32 package (or your private feed) to keep generator/runtime alignment, or
bump both projects to a known-published CsWin32 version and ensure
Microsoft.Windows.SDK.Win32Metadata (70.0.11-preview) remains compatible by
reviewing its release notes for any P/Invoke signature changes before committing
the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a0392049-7d93-4816-846d-64fc0ebe21c3
📒 Files selected for processing (8)
Tests/Tests.csprojsrc/Generator/DeviceManagementPropertiesGenerator.csprojsrc/Nefarius.Utilities.DeviceManagement.csprojsrc/PnP/Devcon.cssrc/PnP/DeviceClassFilters.cssrc/PnP/PnPDevice.Properties.cssrc/PnP/PnPDevice.Static.cssrc/PnP/UsbPnPDevice.cs
Summary by CodeRabbit
Chores
Refactor