This repository was archived by the owner on Jul 10, 2020. It is now read-only.
Fix formElement's config#206
Open
agopaul wants to merge 3 commits into
Open
Conversation
From what I understand, aliases are processed before factories, so when merging the configuration of all ZF modules, the 'aliases/formElement' entry in zend-form takes precedence and the factory entry 'factories/formElement' is ignored. In order to override the zend-form's element, we need to create an alias with that name.
DeepCode's analysis on #aa2530 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the container configuration for
TwbBundle\Form\View\Helper\TwbBundleFormElementandTwbBundle\View\Helper\Navigation.From what I understand, aliases are processed before factories, so when merging the configuration of all ZF modules, the 'aliases/formElement' entry in zend-form takes precedence and the factory entry 'factories/formElement' is ignored.
In order to override the zend-form's element, we need to create an alias with that name.
See #203