Always treat JS bundles as modules

nbudin · nbudin · commit 057a39601c1c · 2025-03-31T10:50:26.000-07:00
diff --git a/app/presenters/cms_rendering_context.rb b/app/presenters/cms_rendering_context.rb
@@ -129,7 +129,7 @@ def liquid_assigns_for_single_page_app(cms_layout)
   def liquid_assigns_for_placeholder_template
     styles_url = url_with_possible_host("/packs/application-styles.js", ENV.fetch("ASSETS_HOST", nil))
     liquid_assigns.merge(
-      "content_for_head" => "#{javascript_include_tag styles_url}{{ content_for_head }}",
+      "content_for_head" => "#{javascript_include_tag styles_url, type: "module"}{{ content_for_head }}",
       "content_for_navbar" => "{{ content_for_navbar }}",
       "content_for_layout" => "{{ content_for_layout }}"
     )
diff --git a/app/views/layouts/graphiql.html.erb b/app/views/layouts/graphiql.html.erb
@@ -3,7 +3,7 @@
   <head>
     <title>GraphiQL</title>
     <%= stylesheet_link_tag url_with_possible_host('/packs/dev-mode-graphiql.css', ENV['ASSETS_HOST']), media: :all %>
-    <%= javascript_include_tag url_with_possible_host('/packs/dev-mode-graphiql.js', ENV['ASSETS_HOST']), defer: true %>
+    <%= javascript_include_tag url_with_possible_host('/packs/dev-mode-graphiql.js', ENV['ASSETS_HOST']), type: 'module', defer: true %>
   </head>
   <body>
     <%= yield %>

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ def liquid_assigns_for_single_page_app(cms_layout)`
`129`	`129`	`def liquid_assigns_for_placeholder_template`
`130`	`130`	`styles_url = url_with_possible_host("/packs/application-styles.js", ENV.fetch("ASSETS_HOST", nil))`
`131`	`131`	`liquid_assigns.merge(`
`132`		`- "content_for_head" => "#{javascript_include_tag styles_url}{{ content_for_head }}",`
	`132`	`+ "content_for_head" => "#{javascript_include_tag styles_url, type: "module"}{{ content_for_head }}",`
`133`	`133`	`"content_for_navbar" => "{{ content_for_navbar }}",`
`134`	`134`	`"content_for_layout" => "{{ content_for_layout }}"`
`135`	`135`	`)`