Skip to content

Wrap all of a signup round in a nested transaction #11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 2 commits into from
Nov 18, 2025
Merged

Wrap all of a signup round in a nested transaction #11126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30b29f7
Wrap all of a signup round in a nested tx
nbudin Nov 18, 2025
cdd1822
fuck the police
nbudin Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions app/services/execute_ranked_choice_signup_round_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def initialize(signup_round:, whodunit:, skip_locking: false, suppress_notificat
@decisions = []
end

def inner_call
def inner_call # rubocop:disable Metrics/MethodLength
prev_round =
signup_round
.convention
Expand All @@ -31,14 +31,16 @@ def inner_call
return success(decisions: []) if signup_round.maximum_event_signups_as_number <= prev_max_signups

with_relevant_locks do
pass_number = 0
loop do
executed_choices_this_pass = execute_pass(pass_number)
break if executed_choices_this_pass.blank?
pass_number += 1
end
ActiveRecord::Base.transaction do
pass_number = 0
loop do
executed_choices_this_pass = execute_pass(pass_number)
break if executed_choices_this_pass.blank?
pass_number += 1
end

ordered_user_con_profiles.update_all(ranked_choice_ordering_boost: 0)
ordered_user_con_profiles.update_all(ranked_choice_ordering_boost: 0)
end
end

success(decisions:)
Expand Down Expand Up @@ -67,7 +69,7 @@ def execute_pass(pass_number)
prev_decisions = @decisions.dup

executed_choices =
ActiveRecord::Base.transaction do
ActiveRecord::Base.transaction(requires_new: true) do
user_con_profiles = ordered_user_con_profiles.to_a
user_con_profiles.reverse! if signup_round.serpentine_ranked_choice_order? && pass_number.odd?

Expand Down
Loading