Skip to content

Better retry configuration for jobs #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 1 commit into from
Nov 21, 2025
Merged

Better retry configuration for jobs #11130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/application_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class ApplicationJob < ActiveJob::Base

queue_as :default

discard_on ActiveJob::DeserializationError do |job, error|
retry_on ActiveJob::DeserializationError, attempts: 3 do |job, error|
ErrorReporting.warn(
"Skipping job because of ActiveJob::DeserializationError (#{error.message})",
arguments: job.arguments
Expand Down
2 changes: 2 additions & 0 deletions app/jobs/send_notification_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# frozen_string_literal: true
class SendNotificationJob < ApplicationJob
retry_on Aws::SES::Errors::Throttling, wait: :polynomially_longer, attempts: 10

def perform(event_key:, options:)
notifier_class = Notifier.notifier_class_for_event_key(event_key)
notifier = notifier_class.new(**options)
Expand Down
Loading