BREAKING! Remove acceptUnsupportedGrammar option

Author: nene

README.md

@@ -198,12 +198,6 @@ Parses SQL string and returns the CST tree. Takes the following options:
   By default a query like `SELECT * FROM tbl WHERE id = ?` will result in parse error.
   To fix it, use `paramTypes: ["?"]` config option.
 - **filename**: `string` Name of the SQL file. This is only used for error-reporting.
-- **acceptUnsupportedGrammar**: `boolean` When enabled, code that would otherwise fail to parse,
-  gets parsed as `unsupported_grammar_stmt` node. That will consume all text until the next semicolon.
-  After the semicolon, parsing will resume as normal. This option is primarily intended as a workaround
-  for using the parser with an SQL dialect that's not yet 100% supported.
-
-  **Deprecated:** use conditional comments instead (see below).
 
 When parsing fails with syntax error, it throws `FormattedSyntaxError` which contains a message like:
 

src/ParserOptions.ts

@@ -25,7 +25,6 @@ export type ParserOptions = {
   includeSpaces?: boolean;
   includeRange?: boolean;
   paramTypes?: ParamType[];
-  acceptUnsupportedGrammar?: boolean;
   /** SQL file name, used when reporting syntax errors */
   filename?: string;
 };

src/parser.pegjs

@@ -40,7 +40,6 @@
     isPlpgsql,
     hasParamType,
     isEnabledWhitespace,
-    isAcceptUnsupportedGrammar,
   } from "./utils/parserState";
   import { isReservedKeyword, isForbiddenImplicitAliasName } from "./utils/keywords";
   import { loc } from "./utils/loc";
@@ -67,7 +66,6 @@ program
 statement
   = non_transaction_statement
   / transaction_statement  // match BEGIN transaction after BEGIN..END block
-  / &{ return isAcceptUnsupportedGrammar(); } x:unsupported_grammar_stmt { return x; }
 
 // This is referenced by BEGIN..END blocks of FUNCTION definitions,
 // which don't allow transactions inside them (specifically it would create a conflict
@@ -9657,13 +9655,6 @@ postgres = &{ return isPostgresql() || isPlpgsql(); } // We're treating PostgreS
 only_postgres = &{ return isPostgresql(); }
 plpgsql = &{ return isPlpgsql(); }
 
-unsupported_grammar_stmt = [^;]+ {
-  return loc({
-    type: "unsupported_grammar_stmt",
-    text: text(),
-  });
-}
-
 /**
  * Generic keyword rules
  */

src/utils/parserState.ts

@@ -33,6 +33,3 @@ export const isEnabledWhitespace = (ws: Whitespace) =>
     (ws.type === "line_comment" || ws.type === "block_comment")) ||
   (getOptions().includeNewlines && ws.type === "newline") ||
   (getOptions().includeSpaces && ws.type === "space");
-
-export const isAcceptUnsupportedGrammar = () =>
-  getOptions().acceptUnsupportedGrammar;

test/statement.test.ts

@@ -38,32 +38,4 @@ describe("statement", () => {
       }
     `);
   });
-
-  describe("with acceptUnsupportedGrammar:true", () => {
-    it("does not produce a syntax error", () => {
-      test("INSERT TODAYS PUZZLE 123;", { acceptUnsupportedGrammar: true });
-    });
-
-    it("parses the code into unsupported_grammar_stmt nodes", () => {
-      expect(parse("INSERT TODAYS PUZZLE 123; WHOOPSIE DAISY;", { acceptUnsupportedGrammar: true }))
-        .toMatchInlineSnapshot(`
-        {
-          "statements": [
-            {
-              "text": "INSERT TODAYS PUZZLE 123",
-              "type": "unsupported_grammar_stmt",
-            },
-            {
-              "text": "WHOOPSIE DAISY",
-              "type": "unsupported_grammar_stmt",
-            },
-            {
-              "type": "empty",
-            },
-          ],
-          "type": "program",
-        }
-      `);
-    });
-  });
 });