Create plots for the input and the output of the SPA Basal Ganglia

[Seanny123]

Partially resolves #411

[tcstewar]

Looks like you forgot to include components/bg_plot.py and possibly a .js file as well... :)

[Seanny123]

😊 fixed it now

[Seanny123]

This pull request is ready for review, however a few caveats before you dig in:

• It both adds legends to value plots and creates bg plots. Should this be split up into two separate pull requests?
• The bg output plot is still present. I remember talking during a meeting about removing it and/or replacing it with something else. Can that be part of another pull request or does it need to be a part of this one?

[Seanny123]

Hmmm... Doesn't seem to be responding to edited actions on reload. Or if you edit the actions at all actually. Or re-order them...

[Seanny123]

Now responds to edits, but just gives the default values labels, which isn't good.

[Seanny123]

This pull request is ready for review again!

[tcstewar]

Here's an interesting bug with how the labels are generated:

• start with examples/tutorial/21-spa-sequence.py
• show the BG input plot (or output plot). This will have labels based on the condition part of each rule.
• comment out one rule that's NOT the last one. So something like:

    actions = spa.Actions(
        'dot(memory, A) --> memory=B',
        'dot(memory, B) --> memory=C',
        #'dot(memory, C) --> memory=D',
        'dot(memory, D) --> memory=E',
        'dot(memory, E) --> memory=A',
        )

The remaining lines will be labelled dot(memory, A), dot(memory, B), dot(memory, C), dot(memory, D) rather than dot(memory, A), dot(memory, B), dot(memory, D), dot(memory, E)

[tcstewar]

If this isn't doing anything other than calling the constructor, I'm not sure it should be defined at all

[Seanny123]

The difference between this calling of the constructor and not defining it at all, is that in this call, I don't assign a label. If this were not defined, a label, which I do not want, would be assigned.

[tcstewar]

Not sure what this means

[Seanny123]

I figure out the bug causing the weird label stuff.

The legend labels are being saved in the config and being reloaded regardless of their relevance, because they're saved as a list and not as a hash. So items of at the end of the list are deleted regardless of the position of the inputs are removed. To fix this, they should be saved as a hash where bg inputs are associated to specific legend labels. To accomplish this, I need to create a new class for bg-plot in JavaScript and I have to extract the legend management code from Value.js. Consequently, I won't be getting around to this for a while.

[tcstewar]

Consequently, I won't be getting around to this for a while.

No problem! We can put this off till 0.3... :)