Visual Component Interface#829
Open
rsimmons1 wants to merge 9 commits into
Open
Conversation
|
@rsimmons1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @drasmuss, @jgosmann and @tcstewar to be potential reviewers. |
Contributor
|
Nice! One bug just from initial playing around: It I make a new object, it will place it inside a sub-Network if the initial click is inside that Network, but if the release location is outside the Network then the object will be drawn such that it looks to be outside the Network, when it's really inside it. |
Contributor
Author
|
hmm interesting, I am pretty sure i know what happening there and should be able to fix it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the new interface for drawing components, as well as a basic configure menu for ensembles and the ability to delete components.
The design is loosely based off google draw in terms of the drag to draw interaction.
Several design components are a temporary implementation including.
However, these are all fully functional.
The rest seems good, really just looking for feedback on the look and feel of the new interface, please mention anything that feels awkward or is missing. Thanks for reviewing!
As well, I'm currently going through the code styling and commenting this PR is just meant for people to try out.