break the convert with #region (#820)

Author: Jim8y

src/Neo.Compiler.CSharp/MethodConvert.cs

@@ -34,6 +34,9 @@ namespace Neo.Compiler
 {
     class MethodConvert
     {
+
+        #region Fields
+
         private readonly CompilationContext context;
         private CallingConvention _callingConvention = CallingConvention.Cdecl;
         private bool _inline;
@@ -55,6 +58,10 @@ class MethodConvert
         private readonly Stack<(SwitchLabelSyntax, JumpTarget)[]> _switchStack = new();
         private readonly Stack<bool> _checkedStack = new();
 
+        #endregion
+
+        #region Properties
+
         public IMethodSymbol Symbol { get; }
         public SyntaxNode? SyntaxNode { get; private set; }
         public IReadOnlyList<Instruction> Instructions => _instructions;
@@ -63,13 +70,21 @@ class MethodConvert
             || (_instructions.Count == 1 && _instructions[^1].OpCode == OpCode.RET)
             || (_instructions.Count == 2 && _instructions[^1].OpCode == OpCode.RET && _instructions[0].OpCode == OpCode.INITSLOT);
 
+        #endregion
+
+        #region Constructors
+
         public MethodConvert(CompilationContext context, IMethodSymbol symbol)
         {
             this.Symbol = symbol;
             this.context = context;
             this._checkedStack.Push(context.Options.Checked);
         }
 
+        #endregion
+
+        #region Variables
+
         private byte AddLocalVariable(ILocalSymbol symbol)
         {
             byte index = (byte)(_localVariables.Count + _anonymousVariables.Count);
@@ -102,6 +117,10 @@ private void RemoveLocalVariable(ILocalSymbol symbol)
                 _localVariables.Remove(symbol);
         }
 
+        #endregion
+
+        #region Instructions
+
         private Instruction AddInstruction(Instruction instruction)
         {
             _instructions.Add(instruction);
@@ -121,6 +140,10 @@ private SequencePointInserter InsertSequencePoint(SyntaxNodeOrToken syntax)
             return new SequencePointInserter(_instructions, syntax);
         }
 
+        #endregion
+
+        #region Convert
+
         public void Convert(SemanticModel model)
         {
             if (Symbol.IsExtern || Symbol.ContainingType.DeclaringSyntaxReferences.IsEmpty)
@@ -547,7 +570,9 @@ private void ConvertSource(SemanticModel model)
             }
             _initslot = !_inline;
         }
+        #endregion
 
+        #region ConvertStatement
         private void ConvertStatement(SemanticModel model, StatementSyntax statement)
         {
             switch (statement)
@@ -1229,6 +1254,10 @@ private void ConvertWhileStatement(SemanticModel model, WhileStatementSyntax syn
             PopBreakTarget();
         }
 
+        #endregion
+
+        #region ConvertExpression
+
         private void ConvertExpression(SemanticModel model, ExpressionSyntax syntax)
         {
             Optional<object?> constant = model.GetConstantValue(syntax);
@@ -3243,6 +3272,21 @@ private void ConvertSwitchExpression(SemanticModel model, SwitchExpressionSyntax
             RemoveAnonymousVariable(anonymousIndex);
         }
 
+        private void ConvertTupleExpression(SemanticModel model, TupleExpressionSyntax expression)
+        {
+            AddInstruction(OpCode.NEWSTRUCT0);
+            foreach (ArgumentSyntax argument in expression.Arguments)
+            {
+                AddInstruction(OpCode.DUP);
+                ConvertExpression(model, argument.Expression);
+                AddInstruction(OpCode.APPEND);
+            }
+        }
+
+        #endregion
+
+        #region ConvertPattern
+
         private void ConvertPattern(SemanticModel model, PatternSyntax pattern, byte localIndex)
         {
             switch (pattern)
@@ -3368,16 +3412,11 @@ private void ConvertNotPattern(SemanticModel model, UnaryPatternSyntax pattern,
             AddInstruction(OpCode.NOT);
         }
 
-        private void ConvertTupleExpression(SemanticModel model, TupleExpressionSyntax expression)
-        {
-            AddInstruction(OpCode.NEWSTRUCT0);
-            foreach (ArgumentSyntax argument in expression.Arguments)
-            {
-                AddInstruction(OpCode.DUP);
-                ConvertExpression(model, argument.Expression);
-                AddInstruction(OpCode.APPEND);
-            }
-        }
+        #endregion
+
+
+
+        #region StackHelpers
 
         private void Push(bool value)
         {
@@ -3510,6 +3549,8 @@ private Instruction PushDefault(ITypeSymbol type)
             });
         }
 
+        #region LabelsAndTargets
+
         private JumpTarget AddLabel(ILabelSymbol symbol, bool checkTryStack)
         {
             if (!_labels.TryGetValue(symbol, out JumpTarget? target))
@@ -3524,6 +3565,8 @@ private JumpTarget AddLabel(ILabelSymbol symbol, bool checkTryStack)
             return target;
         }
 
+        #endregion
+
         private void PushSwitchLabels((SwitchLabelSyntax, JumpTarget)[] labels)
         {
             _switchStack.Push(labels);
@@ -3565,13 +3608,17 @@ private void PopBreakTarget()
             if (_tryStack.TryPeek(out ExceptionHandling? result))
                 result.BreakTargetCount--;
         }
+        #endregion
+
+        #region SlotHelpers
 
         private Instruction AccessSlot(OpCode opcode, byte index)
         {
             return index >= 7
                 ? AddInstruction(new Instruction { OpCode = opcode, Operand = new[] { index } })
                 : AddInstruction(opcode - 7 + index);
         }
+        #endregion
 
         private Instruction IsType(VM.Types.StackItemType type)
         {
@@ -3690,6 +3737,8 @@ private void Throw(SemanticModel model, ExpressionSyntax? exception)
             AddInstruction(OpCode.THROW);
         }
 
+        #region CallHelpers
+
         private Instruction Call(InteropDescriptor descriptor)
         {
             return AddInstruction(new Instruction
@@ -4405,6 +4454,7 @@ private void CallVirtual(IMethodSymbol symbol)
             AddInstruction(OpCode.PICKITEM);
             AddInstruction(OpCode.CALLA);
         }
+        #endregion
     }
 
     class MethodConvertCollection : KeyedCollection<IMethodSymbol, MethodConvert>