Skip to content

Fix: make standalone contract templates use the local compiler tool#1906

Merged
shargon merged 5 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-nep11-tool-manifest
Jul 19, 2026
Merged

Fix: make standalone contract templates use the local compiler tool#1906
shargon merged 5 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-nep11-tool-manifest

Conversation

@Jim8y

@Jim8y Jim8y commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the missing local tool manifest to the NEP-11 template
  • restore and invoke nccs through the local tool manifest in all standalone contract templates
  • document the generated tool manifest
  • validate every template manifest and compiler command

Why

The standalone templates invoked a global nccs command. A clean environment could generate a contract successfully but fail on dotnet build, and the NEP-11 template did not include a tool manifest at all.

Validation

  • template unit tests: 55 passed
  • packed and installed Neo.SmartContract.Template.3.10.0.nupkg
  • generated a clean NEP-11 project from the package
  • Release build restored the local compiler and produced the NEF and manifest with 0 errors
  • targeted dotnet format --verify-no-changes

Part of #1841.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.22%. Comparing base (11bd7a1) to head (7b24709).
⚠️ Report is 4 commits behind head on master-n3.

Additional details and impacted files
@@              Coverage Diff              @@
##           master-n3    #1906      +/-   ##
=============================================
- Coverage      84.23%   84.22%   -0.01%     
=============================================
  Files            308      308              
  Lines          28229    28219      -10     
  Branches        3980     3980              
=============================================
- Hits           23778    23768      -10     
  Misses          3459     3459              
  Partials         992      992              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jim8y
Jim8y marked this pull request as ready for review July 18, 2026 12:23
@Jim8y
Jim8y requested review from ajara87 and shargon July 18, 2026 18:14
@shargon
shargon merged commit de08e95 into neo-project:master-n3 Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants