Skip to content

Fix: detect nested unsupported collection types#1907

Merged
shargon merged 4 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-recursive-collection-types
Jul 19, 2026
Merged

Fix: detect nested unsupported collection types#1907
shargon merged 4 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-recursive-collection-types

Conversation

@Jim8y

@Jim8y Jim8y commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • recursively inspect arrays, pointers, function pointers, containing types, and generic arguments
  • report the first unsupported collection type found inside a supported wrapper
  • preserve support for framework and user-defined collection replacements

Why

CollectionTypesUsageAnalyzer only checked the outer named type. Types such as Tuple<int, List<string>> and Stack<int>[] could bypass NC4013.

Validation

  • collection analyzer tests: 8 passed
  • complete analyzer unit test suite: 285 passed
  • targeted dotnet format --verify-no-changes

Part of #1841.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master-n3@c99492a). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             master-n3    #1907   +/-   ##
============================================
  Coverage             ?   84.23%           
============================================
  Files                ?      308           
  Lines                ?    28229           
  Branches             ?     3980           
============================================
  Hits                 ?    23778           
  Misses               ?     3459           
  Partials             ?      992           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jim8y
Jim8y marked this pull request as ready for review July 18, 2026 12:23
@Jim8y
Jim8y requested review from ajara87 and shargon July 18, 2026 18:14
@shargon
shargon merged commit 11bd7a1 into neo-project:master-n3 Jul 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants