Skip to content

Fix: detect nested floating-point types#1908

Merged
shargon merged 4 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-recursive-floating-types
Jul 19, 2026
Merged

Fix: detect nested floating-point types#1908
shargon merged 4 commits into
neo-project:master-n3from
Jim8y:jim8y/issue1841-recursive-floating-types

Conversation

@Jim8y

@Jim8y Jim8y commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • recursively inspect nested type structures for float, double, and decimal
  • apply the same validation to local variables and public signatures
  • retain array handling and report the actual unsupported inner type

Why

The floating-point analyzers only inspected direct types and array element types. Generic wrappers such as Tuple<int, double> and Wrapper<float> could bypass the contract diagnostics.

Validation

  • floating-point analyzer tests: 7 passed
  • complete analyzer unit test suite: 285 passed
  • targeted dotnet format --verify-no-changes

Part of #1841.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.22%. Comparing base (11bd7a1) to head (3f905c6).
⚠️ Report is 4 commits behind head on master-n3.

Additional details and impacted files
@@              Coverage Diff              @@
##           master-n3    #1908      +/-   ##
=============================================
- Coverage      84.23%   84.22%   -0.01%     
=============================================
  Files            308      308              
  Lines          28229    28219      -10     
  Branches        3980     3980              
=============================================
- Hits           23778    23768      -10     
  Misses          3459     3459              
  Partials         992      992              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jim8y
Jim8y marked this pull request as ready for review July 18, 2026 12:23
@shargon
shargon merged commit 193dfa8 into neo-project:master-n3 Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants