[N3] Preventing redirection from HTTPS to non-HTTPS in Oracle#1050
Conversation
|
Need to check the states. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-n3 #1050 +/- ##
=============================================
- Coverage 48.86% 48.49% -0.37%
=============================================
Files 274 274
Lines 15848 15850 +2
Branches 2022 2023 +1
=============================================
- Hits 7744 7687 -57
- Misses 7620 7627 +7
- Partials 484 536 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do you mean checking whether the StatusCode is in the 3xx range? |
This is for new queries, so states are not affected |
roman-khimov
left a comment
There was a problem hiding this comment.
Had a thought on making it Gorgon-dependent since technically it's a behavior change. But then even if we have mixed plugins on the network they should fall back to ConsensusUnreachable and then request is finished and resulting transaction can't be changed once it's in, so I don't see any way to exploit this.
Port #1049