Skip to content

[N3] Preventing redirection from HTTPS to non-HTTPS in Oracle#1050

Merged
shargon merged 1 commit into
neo-project:master-n3from
ajara87:port-1049
May 21, 2026
Merged

[N3] Preventing redirection from HTTPS to non-HTTPS in Oracle#1050
shargon merged 1 commit into
neo-project:master-n3from
ajara87:port-1049

Conversation

@ajara87
Copy link
Copy Markdown
Member

@ajara87 ajara87 commented May 21, 2026

Port #1049

@github-actions github-actions Bot added the N3 label May 21, 2026
@erikzhang
Copy link
Copy Markdown
Member

Need to check the states.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.49%. Comparing base (87bcd22) to head (cbcea03).

Files with missing lines Patch % Lines
...ins/OracleService/Protocols/OracleHttpsProtocol.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           master-n3    #1050      +/-   ##
=============================================
- Coverage      48.86%   48.49%   -0.37%     
=============================================
  Files            274      274              
  Lines          15848    15850       +2     
  Branches        2022     2023       +1     
=============================================
- Hits            7744     7687      -57     
- Misses          7620     7627       +7     
- Partials         484      536      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ajara87
Copy link
Copy Markdown
Member Author

ajara87 commented May 21, 2026

Need to check the states.

Do you mean checking whether the StatusCode is in the 3xx range?

@shargon
Copy link
Copy Markdown
Member

shargon commented May 21, 2026

Need to check the states.

This is for new queries, so states are not affected

Copy link
Copy Markdown

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a thought on making it Gorgon-dependent since technically it's a behavior change. But then even if we have mixed plugins on the network they should fall back to ConsensusUnreachable and then request is finished and resulting transaction can't be changed once it's in, so I don't see any way to exploit this.

@shargon shargon merged commit 273d729 into neo-project:master-n3 May 21, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants