Fix snapshot point read cache options#1079
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-n3 #1079 +/- ##
=============================================
+ Coverage 50.33% 50.34% +0.01%
=============================================
Files 280 280
Lines 16500 16504 +4
Branches 2137 2137
=============================================
+ Hits 8305 8309 +4
Misses 7632 7632
Partials 563 563 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What improvements have been made? |
|
The improvement is in the snapshot point-read path. Before this change, each storage snapshot used a single read option with The concrete symptom this can cause is high disk read I/O during transaction-heavy consensus processing. The DBFT path does many snapshot point reads while checking existing transactions, conflict hashes, and transaction verification state. When those reads do not populate the DB cache, the same hot storage blocks can be read/decompressed repeatedly instead of being served from the DB cache. On busy nodes this may show up as saturated read I/O and delayed or unresponsive consensus handling. This PR keeps
I also ran a local microbenchmark for repeated snapshot point reads. This is not a full chain benchmark, but it matches the hot point-read pattern this PR changes. Environment:
The main goal is not to speed up scans. The goal is to avoid making normal snapshot point reads behave like bulk scans from the cache perspective. |
|
But then Contains is not cached? |
Summary
Testing