GGP-460: testing with @neo4j-labs/temp-dbs#148
Open
nossila wants to merge 3 commits into
Open
Conversation
nossila
force-pushed
the
test-with-temp-db
branch
2 times, most recently
from
June 30, 2021 22:43
c77b0d8 to
2c6a786
Compare
fbiville
reviewed
Jul 1, 2021
fbiville
left a comment
Contributor
There was a problem hiding this comment.
Is there more context I can read about this proposed change?
I personally would prefer to stick to a single way of running acceptance tests for all the movies repositories here.
This is currently embodied by https://github.com/neo4j-examples/movies-harness/.
| @@ -0,0 +1,25 @@ | |||
| version: 2.1 | |||
Contributor
There was a problem hiding this comment.
I think it'd be preferable to stick to GitHub Actions since it's already in place.
Collaborator
|
@fbiville the goal is to have an example of using tests using the semi-experimental https://github.com/neo4j-contrib/neo4j-temp-db - we can keep the "real" tests but have the other as an example for third parties to consider for their projects. |
anardusam
approved these changes
Jul 1, 2021
nossila
force-pushed
the
test-with-temp-db
branch
from
July 7, 2021 02:17
b19a6c9 to
83651e4
Compare
temp-db only works with neo4j > 4.0 and can only create databased on enterprise version
nossila
force-pushed
the
test-with-temp-db
branch
from
July 7, 2021 02:47
aaa28ed to
6d8c213
Compare
whatSocks
reviewed
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept of using @neo4j-labs/temp-dbs for creating disposable databases for testing.
How to test:
npm installnpm run test