fix: map 404 responses to NotFoundError in REST and Bridge transports#147
Open
1HazyOne707 wants to merge 2 commits into
Open
fix: map 404 responses to NotFoundError in REST and Bridge transports#1471HazyOne707 wants to merge 2 commits into
1HazyOne707 wants to merge 2 commits into
Conversation
Both RestTransport and BridgeTransport mapped all non-OK HTTP responses to TransportError, including 404s. This broke typed catch blocks that handle missing entities — getEntity() on a non-existent ID would throw TransportError instead of NotFoundError. Fix: check response.status === 404 before the generic error path and throw NotFoundError with the same message. Added NotFoundError import to both transport files. Closes neo4j-labs#125
|
@1HazyOne707 is attempting to deploy a commit to the lyonwj's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hey @lyonwj — could you authorize the Vercel preview when you get a chance? Thanks! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getEntity()throwsTransportErrorinstead ofNotFoundErrorwhen an entity does not exist. This breaks typed catch blocks:Root cause
Both
RestTransportandBridgeTransportmap all non-OK HTTP responses toTransportError, including 404s.Fix
Add a
response.status === 404check before the generic error path in both transports and throwNotFoundErrorwith the same message. AddedNotFoundErrorimport to both files.Closes #125