Skip to content

Commit 79bf155

Browse files
committed
fix(testkit-backend): repair ResultSingle and duplicate returns in ResultList/Peek
1 parent a922567 commit 79bf155

3 files changed

Lines changed: 0 additions & 23 deletions

File tree

testkit-backend/src/Handlers/ResultList.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ public function handle($request): TestkitResponseInterface
8989
$this->repository->addRecords($request->getResultId(), $response);
9090

9191
return $response;
92-
93-
return new DriverErrorResponse($request->getResultId(), $wrapped);
9492
}
9593
throw $e;
9694
}

testkit-backend/src/Handlers/ResultPeek.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ public function handle($request): TestkitResponseInterface
8787
$this->repository->addRecords($request->getResultId(), $response);
8888

8989
return $response;
90-
91-
return new DriverErrorResponse($request->getResultId(), $wrapped);
9290
}
9391
throw $e;
9492
}

testkit-backend/src/Handlers/ResultSingle.php

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ public function handle($request): TestkitResponseInterface
4949
if ($record instanceof TestkitResponseInterface) {
5050
return $record;
5151
}
52-
$record = $this->repository->getRecords($request->getResultId());
53-
if ($record instanceof TestkitResponseInterface) {
54-
$err = new Neo4jException([Neo4jError::fromMessageAndCode('Neo.ClientError.Statement.ResultNotSingle', 'Something went wrong with the result handling')]);
55-
56-
return new DriverErrorResponse($request->getResultId(), $err);
57-
}
5852

5953
$count = $record->count();
6054
if ($count !== 1) {
@@ -67,26 +61,13 @@ public function handle($request): TestkitResponseInterface
6761

6862
return $response;
6963
}
70-
$count = $record->count();
71-
if ($count !== 1) {
72-
$err = new Neo4jException([Neo4jError::fromMessageAndCode(
73-
'Neo.ClientError.Statement.ResultNotSingle',
74-
sprintf('Expected exactly one result row, found %d.', $count)
75-
)]);
76-
77-
return new DriverErrorResponse($request->getResultId(), $err);
78-
}
7964

8065
$values = [];
8166
foreach ($record->getAsCypherMap(0) as $value) {
8267
$values[] = CypherObject::autoDetect($value);
8368
}
8469

8570
$this->repository->removeRecords($request->getResultId());
86-
$values = [];
87-
foreach ($record->getAsCypherMap(0) as $value) {
88-
$values[] = CypherObject::autoDetect($value);
89-
}
9071

9172
return new RecordResponse($values);
9273
} catch (Neo4jException $e) {

0 commit comments

Comments
 (0)