Skip to content

Fix Psalm error for static analysis #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p123-stack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Psalm error for static analysis #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Formatter/Specialised/BoltOGMTranslator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ private function makeFromBoltPath(BoltPath $path): Path
$relationships[] = $this->makeFromBoltUnboundRelationship($rel);
}
/** @var list<int> $ids */
$ids = $path->ids;
$ids = $path->indices;
Copy link
Copy Markdown
Collaborator

@transistive transistive May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with this. Please confirm if our current minimum installable bolt version still uses ids instead of indices. In that case, we'll have to upgrade the minimum installable bolt version

Copy link
Copy Markdown
Collaborator Author

@p123-stack p123-stack May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this — I checked the current constraint (^7.1.4) and confirmed the minimum installable bolt version still uses Path::$ids only. Path::$indices was added in 7.4.0, so using indices here would break 7.1.4–7.3.x unless we bump the minimum bolt version. I can either revert back to ids or bump the constraint to ^7.4.0, whichever you’d prefer.


return new Path(
new CypherList($nodes),
Expand Down
2 changes: 1 addition & 1 deletion testkit
Open in desktop
Submodule testkit updated 1 files
+10 −7 tests/stub/iteration/test_result_list.py
Loading