feat: implement BookmarkManager API for shared session bookmarks#317
Open
p123-stack wants to merge 2 commits into
Open
feat: implement BookmarkManager API for shared session bookmarks#317p123-stack wants to merge 2 commits into
p123-stack wants to merge 2 commits into
Conversation
p123-stack
commented
Jun 24, 2026
p123-stack
commented
Collaborator
- Implements BookmarkManager API (aligned with Java 6.x + TestKit Feature:API:BookmarkManager)
- Adds BookmarkManagerInterface, Neo4jBookmarkManager, NoOpBookmarkManager, BookmarkManagers::defaultManager()
- Adds SessionBookmarkTracker to merge manager + session bookmarks and propagate server bookmarks
- Wires sync into Session, BoltUnmanagedTransaction, BoltCommitMessage, SummarizedResultFormatter
- Sends routingBookmarks on cluster ROUTE via Neo4jConnectionPool
- Extends TestKit backend: NewBookmarkManager, supplier/consumer callbacks, bookmarkManagerId on NewSession
- Fixes managed txs: tx_metadata on BEGIN only, not on RUN
Implement Neo4jBookmarkManager with supplier/consumer hooks, sync bookmarks on BEGIN/RUN/COMMIT via SessionBookmarkTracker, and expose the feature to TestKit through NewBookmarkManager, callback dispatch, and session wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.