-
Notifications
You must be signed in to change notification settings - Fork 92
Replace list with show where possible #3084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renetapopova
wants to merge
1
commit into
neo4j:dev
Choose a base branch
from
renetapopova:dev-change-list-to-show
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,7 +78,7 @@ GRANT CREATE AUTH RULE ON DBMS TO authRuleAdder; | |
|
|
||
| As a result, the `authRuleAdder` role has privileges that allow adding auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleAdder` as commands, use the following query: | ||
| To show all privileges for the role `authRuleAdder` as commands, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
@@ -106,7 +106,7 @@ GRANT RENAME AUTH RULE ON DBMS TO authRuleNameModifier; | |
|
|
||
| As a result, the `authRuleNameModifier` role has privileges that allow renaming auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleNameModifier`, use the following query: | ||
| To show all privileges for the role `authRuleNameModifier`, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
@@ -134,7 +134,7 @@ GRANT ALTER AUTH RULE ON DBMS TO authRuleModifier; | |
|
|
||
| As a result, the `authRuleModifier` role has privileges that allow modifying auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleModifier`, use the following query: | ||
| To show all privileges for the role `authRuleModifier`, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
@@ -170,7 +170,7 @@ GRANT DROP AUTH RULE ON DBMS TO authRuleDropper; | |
|
|
||
| As a result, the `authRuleDropper` role has privileges that allow deleting auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleDropper`, use the following query: | ||
| To show all privileges for the role `authRuleDropper`, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
@@ -186,9 +186,9 @@ a|Rows: 1 | |
| |=== | ||
|
|
||
| [[grant-list-auth-rule-privilege]] | ||
| == Grant privilege to list auth rules | ||
| == Grant privilege to show auth rules | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here, for instance, the change in header is risk-free in terms of causing broken links. |
||
|
|
||
| You can grant the privilege to list auth rules using the `SHOW AUTH RULE` privilege. | ||
| You can grant the privilege to show auth rules using the `SHOW AUTH RULE` privilege. | ||
| A role with this privilege is allowed to execute the `SHOW AUTH RULES` administration commands. | ||
| It also grants the role the ability to show auth rules assigned to roles with the `SHOW RULES WITH AUTH RULES` command. | ||
|
|
||
|
|
@@ -199,9 +199,9 @@ The following query shows an example of how to grant the `SHOW AUTH RULE` privil | |
| GRANT SHOW AUTH RULE ON DBMS TO authRuleViewer; | ||
| ---- | ||
|
|
||
| As a result, the `authRuleViewer` role has privileges that allow listing auth rules. | ||
| As a result, the `authRuleViewer` role has privileges that allow showing auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleViewer` as commands, use the following query: | ||
| To show all privileges for the role `authRuleViewer` as commands, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
@@ -218,7 +218,7 @@ a|Rows: 1 | |
|
|
||
| == Grant privilege to manage auth rules | ||
|
|
||
| You can grant the privilege to create, rename, modify, delete, and list auth rules using the `AUTH RULE MANAGEMENT` privilege. + | ||
| You can grant the privilege to create, rename, modify, delete, and show auth rules using the `AUTH RULE MANAGEMENT` privilege. + | ||
| For example: | ||
|
|
||
| [source, cypher, role=noplay] | ||
|
|
@@ -228,7 +228,7 @@ GRANT AUTH RULE MANAGEMENT ON DBMS TO authRuleManager; | |
|
|
||
| As a result, the `authRuleManager` role has all privileges to manage auth rules. | ||
|
|
||
| To list all privileges for the role `authRuleManager` as commands, use the following query: | ||
| To show all privileges for the role `authRuleManager` as commands, use the following query: | ||
|
|
||
| [source, cypher, role=noplay] | ||
| ---- | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a broader question I have: does it not make sense to use header anchors in the Ops Manual? Changing these headers may result in broken links from, e.g. the cypher manual and having anchors adds an extra layer of stability.